Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Gopls from setup in ".devcontainer" since it's now enabled in VS Code by default. #14

Closed
KEINOS opened this issue Jan 28, 2021 · 1 comment

Comments

@KEINOS
Copy link
Owner

KEINOS commented Jan 28, 2021

TL; DR

Remove Gopls form the Dockerfile for .devcontainer

# gopls (language server)
# `gopls` will install the packages in the URL below as well.
# https://github.com/golang/vscode-go/blob/master/docs/tools.md#table-of-contents
"golang.org/x/tools/gopls@latest" \

TS; DR

As of Go for VS Code v0.22.0, the VS Code extension will enable Gopls by default.

It still works as is now, and we need to concern the side effects to "Codespaces". But why not let the VS Code do it for us?

スクリーンショット 2021-01-28 9 29 04

Here's the list of tools that will be installed by default when the extension gets installed.

  • Tools | Docs | VS Code Go | Golang @ GitHub
@KEINOS
Copy link
Owner Author

KEINOS commented Feb 9, 2021

May not be needed to remove

I confirm that installing the Go extension of VSCode will activate gopls. But the version of gopls in the base image mcr.microsoft.com/vscode/devcontainers/go of the container is v0.6.4. Which is an older version.

So leaving as is and let go get -u -v update the gopls package seems to be fine.

@KEINOS KEINOS closed this as completed in aae3ba5 Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant