New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make funtions more functional #20

Open

KGergo88 opened this issue May 2, 2019 · 0 comments

Assignees

Labels

Owner

KGergo88 commented May 2, 2019 •

edited

Loading

Make a code review based on this cool article. Also take into accout how you can improve performance with this other cool article.

Keywords:

Return by value, RVO, NRVO, copy elision instead returning references
Exceptions / std::optional instead of bool return
Structured Bindings instead of reference parameter outputs

Suspection:

The MeasurementDataProtocol is not efficiently returning the Diagrams because the data will be copied first to the std::istream then to the Diagram then the diagram will be copied to the std::vector

KGergo88 added the enhancement label

KGergo88 self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment