Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate source_bundle shebang (in ./train) #67

Open
jfri3d opened this issue Nov 6, 2019 · 0 comments
Open

validate source_bundle shebang (in ./train) #67

jfri3d opened this issue Nov 6, 2019 · 0 comments
Assignees
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers

Comments

@jfri3d
Copy link
Contributor

jfri3d commented Nov 6, 2019

What is the desired change?

Enforce validation of the ./train executable within the source_bundle to ensure a shebang exists!!!

#!/usr/bin/env XXXXXX

ALSO ensure documentation is adjusted to "remind" users that the Train Pipeline uses ./train as an executable.

How will this change improve kaos?

Improve usability to avoid broken trainings where ./train can't run...

Any thoughts on the implementation approach?

Validate in the backend. Inspiration below.

def validate_bundle_structure(cls, directory, req_files):

@jfri3d jfri3d added documentation Improvements or additions to documentation good first issue Good for newcomers labels Nov 6, 2019
@ms-shankar ms-shankar self-assigned this Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants