Skip to content
This repository has been archived by the owner on Jun 22, 2024. It is now read-only.

Rework train_if functionality in online learning #117

Closed
benHeid opened this issue Jun 23, 2021 · 0 comments · Fixed by #177 · May be fixed by #118
Closed

Rework train_if functionality in online learning #117

benHeid opened this issue Jun 23, 2021 · 0 comments · Fixed by #177 · May be fixed by #118
Assignees
Labels
core The issue relates to the core medium This issue has a medium priority

Comments

@benHeid
Copy link
Collaborator

benHeid commented Jun 23, 2021

The train_if argument is evaluated when the model is fitted, which happens before the transformation. However, refit should be applied after a transformation. Moreover, instead of using a function for train_if we should use a condition object, which gets the output of steps as input and no complicated workarounds has to be done by the user like storing the result of a FunctionModule in global variable which is then evaluated by the train_if function. See #116

@benHeid benHeid added the core The issue relates to the core label Jun 23, 2021
@benHeid benHeid self-assigned this Jun 23, 2021
@benHeid benHeid added the medium This issue has a medium priority label Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
core The issue relates to the core medium This issue has a medium priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant