Skip to content
This repository has been archived by the owner on Jun 22, 2024. It is now read-only.

RollingRMSE: Extraction time index from the wrong data #124

Closed
benHeid opened this issue Jul 5, 2021 · 0 comments · Fixed by #125
Closed

RollingRMSE: Extraction time index from the wrong data #124

benHeid opened this issue Jul 5, 2021 · 0 comments · Fixed by #125
Assignees
Labels
bug Something isn't working module This issue involves a specific module

Comments

@benHeid
Copy link
Collaborator

benHeid commented Jul 5, 2021

Describe the bug
In Line 79 we extract the time index from kwargs and use this time index on y. This leads to an error if the name of the time index in kwargs and y differs.

Similiar issue in line 85 and 86 where we set the name of the time_index to time. However, in general that would not match the name of the time dimension of the result or of y.

Expected behavior
In all three cases _get_time_indeces(y)[0] is used.

@benHeid benHeid added bug Something isn't working module This issue involves a specific module labels Jul 5, 2021
@benHeid benHeid self-assigned this Jul 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working module This issue involves a specific module
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant