Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawing of triangular surface patches #32

Closed
charlieb opened this issue May 8, 2023 · 2 comments
Closed

Drawing of triangular surface patches #32

charlieb opened this issue May 8, 2023 · 2 comments

Comments

@charlieb
Copy link

charlieb commented May 8, 2023

The drawing routine for surface patches is only good for rectangular patches and makes triangular patches look really weird and wrong. I'm actually not sure if the underlying nec2 engine handles triangular patches but if it does, I'd be happy to submit a pull request for better drawing of triangular patches.

@KJ7LNW
Copy link
Owner

KJ7LNW commented May 8, 2023

Thank you for offering!

Of course patches are welcome. Beware, that code is a bit messy: Refactoring for OpenGL might actually be easier than fixing the old code. If you're interested in fixing the patch rendering, first please review #23 (OpenGL Support).

If you want to fix existing rendering then go for it, but it is slow software line rendering that redraws every frame and OpenGL really would be best since there is an existing branch with alpha support.

@KJ7LNW
Copy link
Owner

KJ7LNW commented Mar 31, 2024

Hi @charlieb, would still gladly accept a triangle drawing PR if you're up to it. If so, then please re-open this issue or post a PR.

@KJ7LNW KJ7LNW closed this as completed Mar 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants