Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullReferenceException on upgrade #1922

Closed
ayan4m1 opened this issue Oct 21, 2016 · 4 comments
Closed

NullReferenceException on upgrade #1922

ayan4m1 opened this issue Oct 21, 2016 · 4 comments
Labels
Bug Something is not working as intended GUI Issues affecting the interactive GUI

Comments

@ayan4m1
Copy link
Contributor

ayan4m1 commented Oct 21, 2016

May be related to #1381 but different progression. Possibly related to this specific mod update, but we should be able to handle the error better.

CKAN Version:
1.20.1-0-gd41fe54

Operating System:
Win10 x64

The issue you are experiencing:

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
   at CKAN.Main._MarkModForUpdate(String identifier)
   at CKAN.Util.Invoke[T](T obj, Action action)
   at CKAN.Main.PostInstallMods(Object sender, RunWorkerCompletedEventArgs e)
   at System.ComponentModel.BackgroundWorker.OnRunWorkerCompleted(RunWorkerCompletedEventArgs e)

How to recreate this issue:

  • Install TextureReplacer 2.5.0.
  • Add upgrade for TextureReplacer 2.5.1
  • On install, exception is thrown in GUI
@politas
Copy link
Member

politas commented Oct 21, 2016

Can you try uninstalling Texture Replacer before installing the new version?

@politas politas added Support Issues that are support requests Bug Something is not working as intended GUI Issues affecting the interactive GUI labels Oct 21, 2016
@ayan4m1 ayan4m1 removed the Support Issues that are support requests label Oct 21, 2016
@ayan4m1
Copy link
Contributor Author

ayan4m1 commented Oct 21, 2016

Yep, fresh install of 2.5.1 with no 2.5.0 doesn't throw the exception. I was planning to investigate more later, just wanted to write it up so I didn't forget.

@politas
Copy link
Member

politas commented Oct 21, 2016

Cool. If we could make upgrades like this and those in #1864 "just work" it would make things much easier for everyone.

@HebaruSan
Copy link
Member

Should be fixed by #2184, as PostInstallMods no longer does this. If there's still a problem, it'll look different and need fresh investigation. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something is not working as intended GUI Issues affecting the interactive GUI
Projects
None yet
Development

No branches or pull requests

3 participants