Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstall will install ALL recommended mods #2688

Closed
linuxgurugamer opened this issue Feb 26, 2019 · 1 comment
Closed

Reinstall will install ALL recommended mods #2688

linuxgurugamer opened this issue Feb 26, 2019 · 1 comment
Labels
Bug Easy This is easy to fix GUI Issues affecting the interactive GUI Relationships Issues affecting depends, recommends, etc.

Comments

@linuxgurugamer
Copy link
Contributor

Current verison of CKAN

When doing a reinstall of a mod, and deselecting all recommended, they all get installed regardless of the settings

@HebaruSan
Copy link
Member

HebaruSan commented Feb 26, 2019

Looks like a duplicate of #2604.
Can you try the pre-release?
https://github.com/KSP-CKAN/CKAN/releases/tag/v1.26.0-PRE1

I take that back, the reinstall flow still has the same problem described in that issue (DefaultOpts should be DependsOnlyOpts):

CKAN/GUI/Main.cs

Lines 1168 to 1174 in a971475

// Hand off to centralized [un]installer code
installWorker.RunWorkerAsync(
new KeyValuePair<List<ModChange>, RelationshipResolverOptions>(
toReinstall,
RelationshipResolver.DefaultOpts()
)
);

@HebaruSan HebaruSan added Bug Easy This is easy to fix GUI Issues affecting the interactive GUI Relationships Issues affecting depends, recommends, etc. labels Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Easy This is easy to fix GUI Issues affecting the interactive GUI Relationships Issues affecting depends, recommends, etc.
Projects
None yet
Development

No branches or pull requests

2 participants