Not enough space in game folder to install modules on Mac

[DougStoker]

Background

• Operating System: macos catalina
• CKAN Version: 1.31.2
• KSP Version: 1.12.5

Have you made any manual changes to your GameData folder (i.e., not via CKAN)? no

Problem

Describe the bug
crash when download mod

Steps to reproduce

• Go to...
• Click on...
• See error

Expected behavior

Screenshots (if applicable)

CKAN error code (if applicable):

Unhandled Exception:                                                          │
CKAN.NotEnoughSpaceKraken: Not enough space in game folder to install modules!┘
Need to store 2.3 MiB to /Applications/ksp_osx, but only 0 B is available!     
Free up space on that device or change your settings to use another location.

  at CKAN.CKANPathUtils.CheckFreeSpace (System.IO.DirectoryInfo where, System.Int64 bytesToStore, System.String errorDescription) [0x00042] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ModuleInstaller.InstallList (System.Collections.Generic.ICollection`1[T] modules, CKAN.RelationshipResolverOptions options, CKAN.RegistryManager registry_manager, System.Collections.Generic.HashSet`1[System.String]& possibleConfigOnlyDirs, CKAN.IDownloader downloader, System.Boolean ConfirmPrompt) [0x00086] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.InstallScreen.Run (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme, System.Action`1[T] process) [0x00125] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.Toolkit.ConsoleScreen.LaunchSubScreen (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme, CKAN.ConsoleUI.Toolkit.ConsoleScreen cs, System.Action`1[T] newProc) [0x00000] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.ModListScreen.ApplyChanges (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme) [0x00019] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.ModListScreen.<.ctor>b__0_26 (System.Object sender, CKAN.ConsoleUI.Toolkit.ConsoleTheme theme) [0x00000] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.Toolkit.ScreenContainer.Interact (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme) [0x00038] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.Toolkit.ScreenContainer.Run (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme, System.Action`1[T] process) [0x00021] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.ConsoleCKAN..ctor (CKAN.GameInstanceManager mgr, System.String themeName, System.Boolean debug) [0x00089] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.ConsoleUI.Main_ (System.String[] args, CKAN.GameInstanceManager manager, System.String themeName, System.Boolean debug) [0x00005] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.CmdLine.MainClass.ConsoleUi (CKAN.GameInstanceManager manager, CKAN.CmdLine.ConsoleUIOptions opts, System.String[] args) [0x00034] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.CmdLine.MainClass.RunSimpleAction (CKAN.CmdLine.Options cmdline, CKAN.CmdLine.CommonOptions options, System.String[] args, CKAN.IUser user, CKAN.GameInstanceManager manager) [0x002df] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.CmdLine.MainClass.Execute (CKAN.GameInstanceManager manager, CKAN.CmdLine.CommonOptions opts, System.String[] args) [0x00296] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.CmdLine.MainClass.Main (System.String[] args) [0x000e9] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
[ERROR] FATAL UNHANDLED EXCEPTION: CKAN.NotEnoughSpaceKraken: Not enough space in game folder to install modules!
Need to store 2.3 MiB to /Applications/ksp_osx, but only 0 B is available!
Free up space on that device or change your settings to use another location.

  at CKAN.CKANPathUtils.CheckFreeSpace (System.IO.DirectoryInfo where, System.Int64 bytesToStore, System.String errorDescription) [0x00042] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ModuleInstaller.InstallList (System.Collections.Generic.ICollection`1[T] modules, CKAN.RelationshipResolverOptions options, CKAN.RegistryManager registry_manager, System.Collections.Generic.HashSet`1[System.String]& possibleConfigOnlyDirs, CKAN.IDownloader downloader, System.Boolean ConfirmPrompt) [0x00086] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.InstallScreen.Run (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme, System.Action`1[T] process) [0x00125] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.Toolkit.ConsoleScreen.LaunchSubScreen (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme, CKAN.ConsoleUI.Toolkit.ConsoleScreen cs, System.Action`1[T] newProc) [0x00000] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.ModListScreen.ApplyChanges (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme) [0x00019] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.ModListScreen.<.ctor>b__0_26 (System.Object sender, CKAN.ConsoleUI.Toolkit.ConsoleTheme theme) [0x00000] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.Toolkit.ScreenContainer.Interact (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme) [0x00038] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.Toolkit.ScreenContainer.Run (CKAN.ConsoleUI.Toolkit.ConsoleTheme theme, System.Action`1[T] process) [0x00021] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.ConsoleCKAN..ctor (CKAN.GameInstanceManager mgr, System.String themeName, System.Boolean debug) [0x00089] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.ConsoleUI.ConsoleUI.Main_ (System.String[] args, CKAN.GameInstanceManager manager, System.String themeName, System.Boolean debug) [0x00005] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.CmdLine.MainClass.ConsoleUi (CKAN.GameInstanceManager manager, CKAN.CmdLine.ConsoleUIOptions opts, System.String[] args) [0x00034] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.CmdLine.MainClass.RunSimpleAction (CKAN.CmdLine.Options cmdline, CKAN.CmdLine.CommonOptions options, System.String[] args, CKAN.IUser user, CKAN.GameInstanceManager manager) [0x002df] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.CmdLine.MainClass.Execute (CKAN.GameInstanceManager manager, CKAN.CmdLine.CommonOptions opts, System.String[] args) [0x00296] in <79ae9046bd9c43dabfd2f7be4b883034>:0 
  at CKAN.CmdLine.MainClass.Main (System.String[] args) [0x000e9] in <79ae9046bd9c43dabfd2f7be4b883034>:0

[rob5408]

Same, except I have 110GB free. I tried changing DownloadCacheDir to a different location and changed CacheSizeLimit to a a very very large number and it still failed.

[HebaruSan]

Here's the logic we use for checking free space, in case either of you wants to audit it for things that wouldn't work on a Mac:

CKAN/Core/CKANPathUtils.cs

Lines 200 to 212 in 04034c0

	public static void CheckFreeSpace(DirectoryInfo where, long bytesToStore, string errorDescription)
	{
	var bytesFree = where.GetDrive()?.AvailableFreeSpace;
	if (bytesFree.HasValue && bytesToStore > bytesFree.Value) {
	throw new NotEnoughSpaceKraken(errorDescription, where,
	bytesFree.Value, bytesToStore);
	}
	log.DebugFormat("Storing {0} to {1} ({2} free)...",
	CkanModule.FmtSize(bytesToStore),
	where.FullName,
	bytesFree.HasValue ? CkanModule.FmtSize(bytesFree.Value)
	: "unknown bytes");
	}

CKAN/Core/Extensions/IOExtensions.cs

Lines 12 to 56 in 04034c0

	private static bool StringArrayStartsWith(string[] child, string[] parent)
	{
	if (parent.Length > child.Length)
	{
	// Only child is allowed to have extra pieces
	return false;
	}
	var opt = Platform.IsWindows ? StringComparison.InvariantCultureIgnoreCase
	: StringComparison.InvariantCulture;
	for (int i = 0; i < parent.Length; ++i)
	{
	if (!parent[i].Equals(child[i], opt))
	{
	return false;
	}
	}
	return true;
	}
	/// <summary>
	/// Check whether a given path is an ancestor of another
	/// </summary>
	/// <param name="parent">The path to treat as potential ancestor</param>
	/// <param name="child">The path to treat as potential descendant</param>
	/// <returns>true if child is a descendant of parent, false otherwise</returns>
	public static bool IsAncestorOf(this DirectoryInfo parent, DirectoryInfo child)
	=> StringArrayStartsWith(
	child.FullName.Split(new char[] {Path.DirectorySeparatorChar},
	StringSplitOptions.RemoveEmptyEntries),
	parent.FullName.Split(new char[] {Path.DirectorySeparatorChar},
	StringSplitOptions.RemoveEmptyEntries));
	/// <summary>
	/// Extension method to fill in the gap of getting from a
	/// directory to its drive in .NET.
	/// Returns the drive with the longest RootDirectory.FullName
	/// that's a prefix of the dir's FullName.
	/// </summary>
	/// <param name="dir">Any DirectoryInfo object</param>
	/// <returns>The DriveInfo associated with this directory</returns>
	public static DriveInfo GetDrive(this DirectoryInfo dir)
	=> DriveInfo.GetDrives()
	.Where(dr => dr.RootDirectory.IsAncestorOf(dir))
	.OrderByDescending(dr => dr.RootDirectory.FullName.Length)
	.FirstOrDefault();

At a guess, maybe GetDrives() doesn't work?

[rob5408]

Yeah my guess too, I'm trying to ./build osx on my Mac but getting errors (I've been writing up an issue for that here). I got two hours into debugging it last night and realized I was basically just doing my day job instead of playing KSP so I took a break, ha.