Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: alert the user when the repository is older than some threshold #4130

Closed
JonnyOThan opened this issue Jul 25, 2024 · 9 comments · Fixed by #4133
Closed

[Feature]: alert the user when the repository is older than some threshold #4130

JonnyOThan opened this issue Jul 25, 2024 · 9 comments · Fixed by #4133
Labels
AutoUpdate Issues affecting the automatic updating Enhancement New features or functionality GUI Issues affecting the interactive GUI

Comments

@JonnyOThan
Copy link
Contributor

Some people aren’t getting mod updates because they don’t have “update repositories on launch” enabled and they never click refresh.

Can we pop up an alert when the repository has not been updated in >X days? Maybe with a button to just turn on auto updates.

@JonnyOThan JonnyOThan added Enhancement New features or functionality GUI Issues affecting the interactive GUI AutoUpdate Issues affecting the automatic updating labels Jul 25, 2024
@HebaruSan
Copy link
Member

HebaruSan commented Jul 25, 2024

A recurring popup could be very annoying for people who are doing that intentionally for whatever reason (feeling that a snapshot in time is adequate for their install, involuntary air gap, whatever). What about something in the status bar like ConsoleUI does?

image

image

(Although now that I look at it, that is done by timestamping registry.json, which means it's broken now since after #3904, that file no longer holds the available modules...)

@JonnyOThan
Copy link
Contributor Author

JonnyOThan commented Jul 25, 2024

I agree about the popup, which is why X should be a fairly long time (weekly? 2 weeks?). But I just had someone tell me that they couldn't find tweakscale rescaled on ckan because they hadn't refreshed since it was released.

The status bar would never be noticed by anyone. I'd be fine if the popup also has a button that says "don't update and stop asking"

Actually...I think the "refresh on launch" option should be enabled by default and you have to opt out via the settings menu. Get rid of the popup on first boot.

So, possible buttons for the popup:

  • Update now
  • Don't update
  • Update and turn on auto-refresh
  • Don't update and stop asking

@HebaruSan
Copy link
Member

Anything we do will have pros and cons, but wow, that many complicated options in a popup... yeah, no.

Maybe we can borrow a page from social media and put a little alert icon on the Refresh button to draw the user's attention, then put an explanation in the tooltip:

image

image

@JonnyOThan
Copy link
Contributor Author

JonnyOThan commented Jul 25, 2024

Looks good to me (but I still think updating on launch should be on by default)

@HebaruSan
Copy link
Member

I'm leaning against changing that since we already have user feedback against "internet requests without direct authorization" in #2108.

@JonnyOThan
Copy link
Contributor Author

7 years ago from someone who didn't respond to questions?

I'd say the needs of the many outweigh the needs of the few here. Just this week I've helped two people get updates because they had auto-refresh turned off.

I think a better fix for that guy's issue is to provide a way to cancel the update operation if it's taking too long?

@HebaruSan
Copy link
Member

I said "leaning", not "dead-set against". Yes, it was just one person, but where one person speaks up there are always more with the same thoughts, and I think it's a reasonable point that CKAN should be transparent about how/when it accesses the network.

Did you get a sense of why those two people chose not to enable automatic updates? Did they not understand the popup (which would raise some questions about the usefulness of trying to fix this with another popup)?

@JonnyOThan
Copy link
Contributor Author

Did you get a sense of why those two people chose not to enable automatic updates? Did they not understand the popup

I don’t know why. But I’d also say that presenting a first-time user with a choice like that is a mistake. Someone who has never used ckan has no way to make an informed decision; they don’t know what it means. Perhaps this could be improved by better wording, but I think it’s better to just let them decide later via settings.

@HebaruSan
Copy link
Member

@JonnyOThan ConsoleUI currently treats 7+ days as stale and 30+ days as very stale.

private const int daysTillStale = 7;
private const int daystillVeryStale = 30;

In my feature branch so far I've been treating 1+ as stale and 7+ as very stale, but I'm thinking these should be consistent. What do you think are actually reasonable thresholds to use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AutoUpdate Issues affecting the automatic updating Enhancement New features or functionality GUI Issues affecting the interactive GUI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants