-
-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mod]: RasterPropMonitor Part list and Checklist #9874
Comments
Mod analyzer output: spec_version: v1.18
identifier: RPM-PartsList
tags:
- plugin
install:
- find: RPM_Parts_Checklist
install_to: GameData Presumably we need to depend on RPM as well (at least). |
I think the only dependency should be "ASET Consolidated Props Pack". It already depends on RPM. And this plugin only adds the logic for some pages to be displayed on an ASET multi-function display. |
Thanks @Fedex75. What about game version compatibility? 1.12.x? |
@HebaruSan. I only tested it in 1.12.5 |
I’m going to be flying for a bit but make sure to check whether it should depend on rpm vs rpm-core |
@JonnyOThan. It will depend on "ASET Consolidated Props Pack" which in turn depends on rpm-core. I'm working on a pull request for ASET that will add a "Parts List" and a "Checklist" page to the ALCORMFD40x20 (in the future i might also add them to the other MFDs). Hopefully you guys will like it. This plugin only adds the logic to render those pages. |
ASET props may not always depend on rpm core. In general I don’t think I have a preference on including indirect dependencies unless there’s some plausible reason they may change in the future |
I'm not completely sure whether this applies in this case, but you can add RPM pages with a ModuleManager patch in your own mod, without waiting for another mod to update: |
The thing is that, since i wanted to add two pages, i combined the "VESSEL VIEW" and "EXTRA CAMERAS" pages into a single button. And i assigned my pages to the button that was left free. That requires a change in one of ASET's cfg files. I hope that makes sense |
OK, it sounds like we're waiting for that pull request, then. I guess we'll see whether that mod's maintainers want to merge those buttons and have a button that does nothing when your mod isn't installed. |
Working on it as we speak. Just making some final tests |
Just published the pull request |
Ugh I wish there was a better way to extend the functionality of the mfd. its a nightmare |
Hi @Fedex75, it looks like there hasn't been any progress on that other pull request. It's possible that the maintainers of ASET-Consolidated-Props may not opt to merge those changes. Is there any other way your mod could work? |
@HebaruSan i honestly don’t know enough about mods. This is the first time i’m doing any of this. But i don’t think it’s possible because it requires changing some of the files of ASET-Consolidated-Props. I guess this is the end of the road, thanks though |
@Fedex75, well, Module Manager specializes in changing the configuration of other mods. Could a Module Manager patch be created to integrate your mod into the others? |
I intend to get around to this eventually...I'm not super stoked about the idea of tweaking core page layouts in order to support specific other mods. The base problem is that the MFD pages are very much NOT built for easy extension and modification like you want to do. I'd love to explore ways to make that better but it's just very low on my priority list. |
Hey @Fedex75, please let us know if StoneBlue/ASET-Consolidated-Props#27 ever gets merged and a release created. We can re-open this then. Thanks! |
Mod Name
RasterPropMonitor Part list and Checklist
Author(s)
Fedex75
License
GPL-3.0
Homepage link
https://github.com/Fedex75/RPM_Parts_Checklist/
Download link
https://github.com/Fedex75/RPM_Parts_Checklist/releases/
The text was updated successfully, but these errors were encountered: