Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak as reported by KSPCF? #13

Closed
Capkirk123 opened this issue May 5, 2024 · 2 comments
Closed

Fix memory leak as reported by KSPCF? #13

Capkirk123 opened this issue May 5, 2024 · 2 comments

Comments

@Capkirk123
Copy link
Member

Someone who understands the RA codebase should investigate this DRVeyl#90
@DRVeyl
Copy link

DRVeyl commented May 5, 2024

The PR itself is fine but overly verbose and can be replaced with just a blind
GameEvents.onGameSceneLoadRequested.Remove(OnSceneChange); at that location.

@siimav
Copy link

siimav commented Jun 14, 2024

Fixed in 3aa95fc

@siimav siimav closed this as completed Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@siimav @Capkirk123 @DRVeyl