Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Bad selection menu on Chrome mobile #391

Closed
Monniasza opened this issue Sep 14, 2021 · 6 comments · Fixed by #398
Closed

[Bug] Bad selection menu on Chrome mobile #391

Monniasza opened this issue Sep 14, 2021 · 6 comments · Fixed by #398
Labels
Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Low Type: Improvement

Comments

@Monniasza
Copy link

Description (What went wrong?):
The menu is transparent and hard to read

Reproduction Steps (What did you do?):
Open menu with [≡] button

Expected Behavior (What do you think should have happened instead?):
The menu is opaque

Environment (OS/Browser/Plugins/etc):
Browser: Google Chrome
OS: Android 10 KQK1.200114.002

Extra Information (Screenshots/Error Messages/Javascript Console Output):
Screenshot_2021-09-14-20-29-25-586_com android chrome

@V1TA5
Copy link
Contributor

V1TA5 commented Sep 14, 2021

SpaceDock is sadly not compatible with mobile devices in portrait mode.

@HebaruSan HebaruSan added Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Low Type: Improvement labels Sep 14, 2021
@HebaruSan
Copy link
Contributor

Seems to be built into Bootstrap. If I disable this property, it ceases to be transparent:

image

image

image

Probably not worth trying to fight the frawework.

@V1TA5
Copy link
Contributor

V1TA5 commented Sep 14, 2021

I wonder why that exists. My guess would be: The template is using things wrong.

Btw heres my Mantra again: lets redo the templates.

@HebaruSan
Copy link
Contributor

The template is about as simple as can be in this case, probably not doing anything wrong:

<ul class="dropdown-menu" >
<li>
<a href="#" data-toggle="modal" data-target="#loginModal">Login</a>
</li>
{% if registration %}
<li><a href="{{ url_for("accounts.register") }}">Register</a></li>
{% endif %}
<li class="divider"></li>
<li><a href="{{ donation_link }}" target="_BLANK">Donate</a></li>
<li class="divider"></li>
<li><a href="/random">Random Mod</a></li>
<li><a href="/blog">Blog</a></li>
</ul>

Not sure what that implies for your mantra.

@HebaruSan
Copy link
Contributor

Actually it looks like you did this, @V1TA5: 75c918d

Since it's one of these ill-advised hacks in the bootstrap files, and there's no documentation of what you were trying to fix, maybe we can just revert it.

@HebaruSan
Copy link
Contributor

And it was pointed out soon after that:

#145 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Frontend Related to HTML, JS, CSS, or other browser things Priority: Low Type: Improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants