Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break CI if there are more than 1 file changes #2583

Open
algomaster99 opened this issue Oct 2, 2024 · 2 comments · May be fixed by #2644
Open

Break CI if there are more than 1 file changes #2583

algomaster99 opened this issue Oct 2, 2024 · 2 comments · May be fixed by #2644
Assignees
@RafDevX

Comments

@algomaster99
Copy link
Collaborator

algomaster99 commented Oct 2, 2024 •
edited
Loading

Some PRs have more than 1 file change. Example: #2552. The CI should break if this is the case.

Conditions:

  • File changes should be exactly 1. Not sure if we should allow 0 file changes, but let's be strict.

EDIT: updated the list of conditions.
@RafDevX
Copy link
Contributor

RafDevX commented Oct 2, 2024

@ludvigch and I would like to work on this issue for our open source contribution. May we?

@algomaster99
Copy link
Collaborator Author

Go for it! Do submit a proposal PR as well.

@RafDevX RafDevX mentioned this issue Oct 7, 2024
Merged
@algomaster99 algomaster99 mentioned this issue Oct 11, 2024
Closed
@RafDevX RafDevX linked a pull request Oct 13, 2024 that will close this issue
Open
@ludvigch ludvigch mentioned this issue Oct 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RafDevX RafDevX

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check files affected by task contribution Pull Requests ludvigch/devops-course
2 participants
@algomaster99 @RafDevX