fix: Respect catcode in macro expansion and set ~'s catcode correctly #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support single characters having a catcode of 13 (active) or 12 (other), and expand a macro defined for the character only if it's active. This enables defining `~` as a macro, but avoiding expansion in URLs. Fix #2924
ylemkimon
approved these changes
Apr 24, 2021
Codecov Report
@@ Coverage Diff @@
## master #2949 +/- ##
=======================================
Coverage 93.94% 93.95%
=======================================
Files 87 87
Lines 6327 6332 +5
Branches 1309 1311 +2
=======================================
+ Hits 5944 5949 +5
Misses 353 353
Partials 30 30
Continue to review full report at Codecov.
|
KaTeX-bot
added a commit
that referenced
this pull request
Apr 24, 2021
## [0.13.3](v0.13.2...v0.13.3) (2021-04-24) ### Bug Fixes * Respect catcode in macro expansion and set ~'s catcode correctly ([#2949](#2949)) ([01ae7f8](01ae7f8)), closes [#2924](#2924) * **array:** Keep single empty row in AMS environments ([#2947](#2947)) ([24332e0](24332e0)), closes [#2944](#2944)
|
🎉 This PR is included in version 0.13.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support single characters having a catcode of 13 (active) or 12 (other), and expand a macro defined for the character only if it's active.
This enables defining
~as a macro, but avoiding expansion in URLs and\char,which fixes #2924.
The method of asking the lexer for the current catcode does not match TeX's behavior. In TeX, the lexer returns a catcode along with every token, and the macro expander uses that catcode, instead of the current one (which can differ). I'm leaving this for future work... but could try if desired.