Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for pre-commit hooks? #539

Open
Jarmos-san opened this issue Jul 22, 2023 · 1 comment · May be fixed by #565
Open

Support for pre-commit hooks? #539

Jarmos-san opened this issue Jul 22, 2023 · 1 comment · May be fixed by #565
Labels
A-bin Area: selene, the program C-enhancement Category: Feature request or improvement

Comments

@Jarmos-san
Copy link

There is this tool called pre-commit which supports creating and managing multi-language pre-commit hooks easily. I believe you only need to add a .pre-commit-hooks.yaml file to the repository and the pre-commit tool will take care of compiling and invoking the binary when necessary! I use Lua (and Selene) both at work and for personal projects besides other languages (and tools) hence having one single tool to manage our pre-commit hooks is necessary.

There is more information in the "Creating New Hooks" section of the docs. If you are willing to support pre-commit hooks for Selene, I think I can write a config for the hook and share a PR. So let me know your thoughts?

@Kampfkarren
Copy link
Owner

From a quick glance at that section this looks okay to support.

@Kampfkarren Kampfkarren added C-enhancement Category: Feature request or improvement A-bin Area: selene, the program labels Jul 23, 2023
@amitds1997 amitds1997 linked a pull request Oct 30, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-bin Area: selene, the program C-enhancement Category: Feature request or improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants