-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
乡 or 幺 in element 雍 #212
Comments
This is fixed by the following pull request: |
I've merged this into the master branch now. I hope I'm not going too fast with these changes, but a lot of work remains to do, so leaving lots of minor changes hanging would make things very confusing I think. |
Just took a quick look and this looks good to me ; although 乡 is only used in 5 kanji total so maybe the use of 幺 was on purpose for some (etymological?) reason. In any case it would be easy to sed back to 幺, so the change looks good. The pace is indeed more than I can follow, but I'll try to review these little by little. :) |
Actually per the format description the |
The element on the lower left of 雍 is given as 幺 in four of the "standard" kanji:
kvg:058c5-g4
kvg:064c1-g5
kvg:07515-g4
kvg:096cd-g3
The bottommost stroke is identified sometimes as ㇔ in 07515 and sometimes as ㇒/㇔ in 064c1.
I think it would be better to change this to 乡 as the element, and be consistent in using ㇒.
I can write a script to automatically edit these all but before doing so, is there any objection to this?
The text was updated successfully, but these errors were encountered: