Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

犮 grouping #213

Closed
benkasminbullock opened this issue Mar 27, 2022 · 1 comment · Fixed by #304
Closed

犮 grouping #213

benkasminbullock opened this issue Mar 27, 2022 · 1 comment · Fixed by #304
Labels
Grouping How individual strokes are grouped

Comments

@benkasminbullock
Copy link
Member

There was an error in stroke labelling in kanji/09aee.svg, but fixing that resulted in breaking the grouping of strokes into 犬.

@benkasminbullock benkasminbullock added the Grouping How individual strokes are grouped label Mar 28, 2022
@benkasminbullock
Copy link
Member Author

This is a consistent problem across multiple files with the 犮 element. The stroke order in the vector diagrams has strokes 1 and 2 as the first strokes of 大, then the third stroke is the down and left stroke, then the fourth stroke is the third stroke of 大, then the last stroke is the upper dash of 犬. All of the groupings I've inspected of this element seem to have strokes 1,2,3 grouped as 大 and then stroke 4 is grouped separately and finally stroke 5 is grouped correctly. I cannot envisage how this error occurred except that someone applied a script to group all these elements in an identical way, and did not inspect the results for consistency. It is such a shame that the original scripts were not released, otherwise the problem could have been fixed at source, but now the only way to unravel this issue is to write another script to edit all these pieces back into order.

@benkasminbullock benkasminbullock changed the title kanji/09aee.svg grouping 犮 grouping Apr 14, 2022
@benkasminbullock benkasminbullock linked a pull request Apr 14, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Grouping How individual strokes are grouped
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant