Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kanji/0881f.svg isn't U+881f nor is it 蝋 #281

Closed
benkasminbullock opened this issue Apr 8, 2022 · 3 comments · Fixed by #380
Closed

kanji/0881f.svg isn't U+881f nor is it 蝋 #281

benkasminbullock opened this issue Apr 8, 2022 · 3 comments · Fixed by #380
Labels
Please check Somebody should check this, but who? Stroke shapes The shapes which strokes take

Comments

@benkasminbullock
Copy link
Member

kanji/0881f doesn't seem to represent the Unicode code point 蠟 since it's missing the top 巛 and the centre right should be 龱. The kvg:element on the topmost group of the paths has a value of 蝋 but it isn't that either.

@benkasminbullock
Copy link
Member Author

Using IDSGrep I was able to find that this is U+27491. There is little information about the character, e.g. Wiktionary is blank. https://en.wiktionary.org/wiki/%F0%A7%92%91

@benkasminbullock benkasminbullock added Error Things which are definitely wrong Stroke shapes The shapes which strokes take and removed Error Things which are definitely wrong labels Apr 8, 2022
@SlugFiller
Copy link

This character was added in c0a02f3, but I'm not sure where it came from since it doesn't match any of the deleted files.

@benkasminbullock
Copy link
Member Author

benkasminbullock commented May 3, 2022

This character was added in c0a02f3, but I'm not sure where it came from since it doesn't match any of the deleted files.

It was moved from kanji_mismatch/0874b-Jinmei.svg to its current code point in that commit, but, as this issue points out, that seems to have been an error, since it doesn't match that code point either. I don't know why but git says that the file was deleted and the other file created, rather than recording that as a move of a file. Presumably because all the internal IDs changed git doesn't recognise it as the same file. I guess the thing to do is to move the file, commit, then change the IDs, then commit again.

Important edit: this was 0874b-Jinmei.svg, not 0881f-Jinmei.svg.

@benkasminbullock benkasminbullock added the Please check Somebody should check this, but who? label May 5, 2022
@benkasminbullock benkasminbullock linked a pull request May 6, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Please check Somebody should check this, but who? Stroke shapes The shapes which strokes take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants