Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Components of 禸 #83

Closed
ospalh opened this issue Jul 27, 2014 · 3 comments · Fixed by #236
Closed

Components of 禸 #83

ospalh opened this issue Jul 27, 2014 · 3 comments · Fixed by #236
Labels
Please check Somebody should check this, but who?

Comments

@ospalh
Copy link
Member

ospalh commented Jul 27, 2014

禸 and all kanji that use it: missing component information for ム and 冂?
@ospalh
Copy link
Member Author

ospalh commented Jul 27, 2014

This is a repost of a line from #14

@benkasminbullock
Copy link
Member

I was able to confirm that there are some elements with missing component information. For example, kanji/09f72.svg
 is missing the 冂 component, which should be inserted around lines 87 and 88. The issue is complicated by the fact that 禸 is used as a kind of generic catch-all for a variety of constructions.

@benkasminbullock
Copy link
Member

This issue should be fixed by the following commits:

https://github.com/KanjiVG/kanjivg/tree/split-079b8

Can you check it and see if that does the job? If I don't hear anything, I'll go ahead and merge that.

@benkasminbullock benkasminbullock mentioned this issue Mar 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Please check Somebody should check this, but who?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split 079b8 KanjiVG/kanjivg
2 participants
@benkasminbullock @ospalh