Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Downloading] Remove pySmartDL if not used for downloading #63

Open
4 tasks
radujipa opened this issue Sep 9, 2015 · 4 comments
Open
4 tasks

[Downloading] Remove pySmartDL if not used for downloading #63

radujipa opened this issue Sep 9, 2015 · 4 comments

Comments

@radujipa
Copy link
Contributor

radujipa commented Sep 9, 2015

The project was changed to move away from pySmartDL and use aria2 for downloading purposes.

However, pySmartDL was not completely removed from the project and is creating additional python dependencies. (e.g. concurrent module, for which you would need to pip install futures)

  • Investigate current usage of pySmartDL
  • If pySmartDL is not being used for specifically downloading, remove it entirely
  • If pySmartDL is used for other operations (e.g. md5 checks), use lightweight alternatives (i.e. native python)
  • Update wiki pages to reflect changes
@Ealdwulf
Copy link
Contributor

Ealdwulf commented Sep 9, 2015

The linux code in the burner wasn't updated to support aria2. That would be require some thought because it goes against the spirit of linux to supply a binary of aria2 like we do for windows and osx. some options are:

  • Drop linux support
  • Keep pySmartDL just for linux
  • request the user to install aria2 manually if it isn't present

@radujipa
Copy link
Contributor Author

radujipa commented Sep 9, 2015

At the moment, I believe there is an issue with the Linux version mainly because of pyinstaller since it doesn't seem to package PyQt4. This might need some further investigation as to whether this issue has been fixed, or perhaps the packaging process is different on Linux and has been wrong the whole time. I've opened another ticket #64

  • Keeping pySmartDL for Linux creates additional nasty dependencies in OSX and Windows, and I would advise against it
  • It probably won't come as a surprise to the average Linux user to have to install a dependency for an app, so I like this alternative for the time being - in the future if we release the burners on pip, we could add aria2 as a dependency

I would also advise against dropping support for Linux, as the app works fine if run from source. For the tech savy, it may still prove a useful tool with the documentation in the wikis. We might even get external collaboration on it in that case.

@sudhanshuptl
Copy link

Facing issue while downloading file it just break after few 100mb and it show as download comppleted and restart download and loop continue

@Ealdwulf
Copy link
Contributor

We no longer support this tool; we now recommend using etcher

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants