Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Collection deletion prompt doesn't grey out background #1469

Closed
TheIceCreamTroll opened this issue Aug 23, 2022 · 2 comments · Fixed by #1481
Closed

Collection deletion prompt doesn't grey out background #1469

TheIceCreamTroll opened this issue Aug 23, 2022 · 2 comments · Fixed by #1481
Labels
UI Primarily UI impacting

Comments

@TheIceCreamTroll
Copy link
Contributor

Describe the bug
Background doesn't grey out when deleting a collection. Another fun z-index issue.

To Reproduce
Steps to reproduce the behavior:

  1. Go through the steps to delete a collection until you reach the confirmation prompt

Expected behavior
The background should grey out

Screenshots
delete_cover_image

Desktop (please complete the following information):

  • OS: Docker
  • Browser Firefox
  • Version 0.5.5.8
@TheIceCreamTroll TheIceCreamTroll added the needs-triage Needs to be triaged by a developer and assigned a release label Aug 23, 2022
@majora2007 majora2007 added bug Something isn't working UI Primarily UI impacting and removed needs-triage Needs to be triaged by a developer and assigned a release labels Aug 25, 2022
@majora2007
Copy link
Member

This is not an issue. This is because this is a confirm, which is not a modal.

@majora2007 majora2007 removed the bug Something isn't working label Aug 25, 2022
@TheIceCreamTroll
Copy link
Contributor Author

This is not an issue. This is because this is a confirm, which is not a modal.

Looks like it's a regression from the old behavior though, and makes the confirm popup blend into the "Edit Collection" menu

How it used to look:
kavita_Collections_Delete

@majora2007 majora2007 reopened this Aug 25, 2022
@majora2007 majora2007 mentioned this issue Aug 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
UI Primarily UI impacting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tachiyomi + Fixes Kareadita/Kavita
2 participants
@majora2007 @TheIceCreamTroll