Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with Metada (Again) V3 #1510

Closed
Rougecarlos opened this issue Sep 3, 2022 · 2 comments · Fixed by #1511
Closed

Problem with Metada (Again) V3 #1510

Rougecarlos opened this issue Sep 3, 2022 · 2 comments · Fixed by #1511
Labels
needs-triage Needs to be triaged by a developer and assigned a release

Comments

@Rougecarlos
Copy link

Rougecarlos commented Sep 3, 2022

Hi with the new version Kavita 0.5.6, in spanish when i scan the library have a lot of FAIL like this:

fail: API.Services.Tasks.Scanner.ProcessSeries[0]
There was some issue when updating chapter's metadata
System.FormatException: String '10/19/2021' was not recognized as a valid DateTime.
at API.Services.Tasks.Scanner.ProcessSeries.UpdateChapterFromComicInfo(Chapter chapter, ComicInfo info) in C:\Users\josep\Documents\Projects\KavitaOrg\Kavita\API\Services\Tasks\Scanner\ProcessSeries.cs:line 0

When in windows i put regional format in English (EEUU) this issue not show and metadata are well

Maybe for this in spanish some metadata is not showed, in USA the time is set to MONTH/DAY/YEAR but in spain by default is DAY/MONTH/YEAR.

The previus issue #1411

Pd: other thing i was find but not know if is a bug, if in library you select a folder with only the epubs inside it is not recognised, but if you put it in a folder work well

@Rougecarlos Rougecarlos added the needs-triage Needs to be triaged by a developer and assigned a release label Sep 3, 2022
@ThePromidius
Copy link
Contributor

USA the time is set to MONTH/DAY/YEAR but in spain by default is DAY/MONTH/YEAR.

That seems to be the case.
Seems hardcoded.

        if (comicInfo.Year > 0)
        {
            var day = Math.Max(comicInfo.Day, 1);
            var month = Math.Max(comicInfo.Month, 1);
            chapter.ReleaseDate = DateTime.Parse($"{month}/{day}/{comicInfo.Year}");
        }

@tjarls
Copy link
Contributor

tjarls commented Sep 3, 2022

I just took a look at the code and it's definitely a bug. It's also a suboptimal convoluted way of setting a date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs to be triaged by a developer and assigned a release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants