Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Series Covers and Summary being reset when new Chapter Added to series #1578

Closed
Turtlepoker opened this issue Oct 8, 2022 · 5 comments · Fixed by #1582
Closed

Series Covers and Summary being reset when new Chapter Added to series #1578

Turtlepoker opened this issue Oct 8, 2022 · 5 comments · Fixed by #1582
Labels
needs-triage Needs to be triaged by a developer and assigned a release

Comments

@Turtlepoker
Copy link

Turtlepoker commented Oct 8, 2022

If this is a feature request, request here instead. Feature requests will be deleted from Github.

Please put as much information as possible to help me understand your issue. OS, browser, version are very important!

Describe the bug
When a library scan is run , series with new chapter added to their folders have Series Covers (manually set) and Summary (manually set) changed. Series Covers are changed to chapter 1 cover.

Library Named: Webtoons
Type: Comics

File Structure is

Library Root
┠── Series Name A
┖── Series Name A - Episode 1.cbz
┖── Series Name B
┖── Series Name B - Episode 1.cbz

To Reproduce
Steps to reproduce the behavior:

  1. Have series in Library
  2. Set custom Cover Image and Summary
  3. Add new Chapter to Series Folder
  4. Wait for daily library scan or run manual library scan
  5. Set cover imaged replaced by 1st chapter cover, summary erased.

Expected behavior
Library scan should lead to new chapters being updated in Series. Keeping all previous series settings intact.

Screenshots
If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [raspberry pi OS]
  • Browser [firefox 105]
  • Version [0.5.6] recently updated from 0.5.5

Additional context
Previously series would sometime be recognized as name plus episode in title, (example: Cape of Spirits - Episode). I would change name, sort name, and localized name to remove "- Episode" from series title. Cape of Spirits - Episode ==> Cape of Spirits

Repeated error
2022-08-28T15:47:32.8423455-05:00 CRIT [API.Services.Tasks.ScannerService] [0] [ScannerService] There are multiple series that map to normalized key capeofspirits. You can manually delete the entity via UI and rescan to fix it. This will be skippedSystem.InvalidOperationException: Sequence contains more than one matching element
at System.Linq.ThrowHelper.ThrowMoreThanOneMatchException()
at System.Linq.Enumerable.TryGetSingle[TSource](IEnumerable1 source, Func2 predicate, Boolean& found)
at API.Services.Tasks.ScannerService.UpdateLibrary(Library library, Dictionary`2 parsedSeries)

2022-08-28T15:47:32.8496583-05:00 CRIT [API.Services.Tasks.ScannerService] [0] [ScannerService] Duplicate Series Found: cape-of-spirits maps with Cape of Spirits - Episode
2022-08-28T15:47:32.8585765-05:00 CRIT [API.Services.Tasks.ScannerService] [0] [ScannerService] Duplicate Series Found: cape-of-spirits maps with cape-of-spirits
kavita.log

@Turtlepoker Turtlepoker added the needs-triage Needs to be triaged by a developer and assigned a release label Oct 8, 2022
@majora2007
Copy link
Member

This is an easy issue, you are not meeting the scanner's requirement, hence why you're getting resets happening. You cannot have series spread into multiple folders from the Library Root.

I'm going to close it. Once you correct your Scan loop and if you still see this occurring, come back and open the issue or comment and I can provide support or investigation.

https://wiki.kavitareader.com/en/guides/managing-your-files/scanner#file-layout

@Turtlepoker
Copy link
Author

Sorry, Library structure didn't format correctly in my post, This is current structure.
Would this not be the correct file structure?
image
image
image
image

@majora2007
Copy link
Member

Ahh indeed it did not. I am going to guess this is due to some instability with the scan loop. Unfortunately, the nightly has fixed many issues with the scan loop (as v0.5.6 was the first version of the new loop), so debugging this issue isn't possible. Although, the next release is right around the corner, so it should be fixed for you soon.

I'll reopen the ticket for you and can follow up post v0.6 release.

@majora2007 majora2007 reopened this Oct 9, 2022
@Turtlepoker
Copy link
Author

Looking more closely at files, the issue seems to be related to files with "Episode" in name (She's Hopeless - Episode 1.cbz). This results in Series being added as "She's Hopeless - Episode". In previous versions I would just rename in Kavita to "She's Hopeless".
Version 0.5.6 doesn't seem to like changes to "Name"; can edit "Sort Name" and "localized name" just fine. When I change "Name", series seems to get broken.

If I can I try to Scan Series from Series Page this error pops up
Scan for new file from series
Running full library scan results as Series being detected as new (when updated with new chapters). Series is added with original pre-edit title "She's Hopeless - Episode" and new creation date. Thus, resetting my previously set cover, summary, and any other manually set info for series.

Found Solution:
Don't have chapters named with "Episode" in file title.
Incorrect: "She's Hopeless - Episode 1.cbz" or "She's Hopeless Episode 1.cbz"
Correct: "She's Hopeless - Ep 1.cbz" or "She's Hopeless - Ep.1.cbz" or "She's Hopeless Ep 1.cbz

Is this expected or unexpected behavior?

@majora2007
Copy link
Member

Okay, so this issue has become a bit messy. First off, your first issue is due to the bugs in the stable. So I'm going to leave that as that, as it's fixed on nightly and a stable is right around the corner.

For your second issue, it indeed was an issue and thank you for bringing it up. I have corrected the issue where Scan Series on a Series with a custom name in Kavita would cause a deletion. Next time throw that up on a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-triage Needs to be triaged by a developer and assigned a release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants