Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special Keyword Removal #2967

Closed
majora2007 opened this issue May 23, 2024 · 7 comments · Fixed by #3286
Closed

Special Keyword Removal #2967

majora2007 opened this issue May 23, 2024 · 7 comments · Fixed by #3286
Labels
Parser Deals with how we parse data

Comments

@majora2007
Copy link
Member

Remove Extras. Omnibus, etc from Special keywords. Too many false positives. Let's stick to encodings like SP01 only to prevent bad parsing.

@majora2007 majora2007 added the Parser Deals with how we parse data label May 23, 2024
@therobbiedavis
Copy link
Collaborator

I'm ok with this as long as the comicinfo.xml format will still trigger it being a special

@Roshri
Copy link

Roshri commented May 23, 2024

Depending on the library type even if they're present on the xml I think they probably shouldn't be parsed either, afaik CV takes most of those special keywords as different volumes altogether.
Maybe people more invested on this could offer more insight though

@scare376
Copy link
Collaborator

scare376 commented May 24, 2024

I agree. SP markers should be used for marking specials with filename parsing. If someone wants it to have it marked as a certain type of special they should use a comicinfo. Or you could "chain" it with the SP marker in some way with filename parsing.

@slaszt
Copy link

slaszt commented May 28, 2024

I'm fine with this change, people can use comicinfo if they really care that much. Given that there's really no accepted standard for metadata or different types of releases and that many libraries are organized based on personal preference, I think it makes sense not to parse specials so broadly.

@Nebelherr23
Copy link

I have a title where the 'Special' keyword backfired for me...

The Parser decided that "A Returner's Magic should be Special" is all specials of a series named "A Returner's Magic should be".

While I still have a few ways open to fix this, I think that keywords like Omnibus, Annual, Special and what not should not be inferred from Filename, but from metadata. (Filesystem is not metadata.)

@ghost
Copy link

ghost commented Aug 24, 2024

I agree on this one Specials & Extras parsing only backfired on me so far

@majora2007
Copy link
Member Author

I'm moving forward with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Parser Deals with how we parse data
Projects
Development

Successfully merging a pull request may close this issue.

6 participants