-
-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Special Keyword Removal #2967
Comments
I'm ok with this as long as the comicinfo.xml format will still trigger it being a special |
Depending on the library type even if they're present on the xml I think they probably shouldn't be parsed either, afaik CV takes most of those special keywords as different volumes altogether. |
I agree. SP markers should be used for marking specials with filename parsing. If someone wants it to have it marked as a certain type of special they should use a comicinfo. Or you could "chain" it with the SP marker in some way with filename parsing. |
I'm fine with this change, people can use comicinfo if they really care that much. Given that there's really no accepted standard for metadata or different types of releases and that many libraries are organized based on personal preference, I think it makes sense not to parse specials so broadly. |
I have a title where the 'Special' keyword backfired for me... The Parser decided that "A Returner's Magic should be Special" is all specials of a series named "A Returner's Magic should be". While I still have a few ways open to fix this, I think that keywords like Omnibus, Annual, Special and what not should not be inferred from Filename, but from metadata. (Filesystem is not metadata.) |
I agree on this one Specials & Extras parsing only backfired on me so far |
I'm moving forward with this. |
Remove Extras. Omnibus, etc from Special keywords. Too many false positives. Let's stick to encodings like SP01 only to prevent bad parsing.
The text was updated successfully, but these errors were encountered: