Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing settings in reactmap duplicates entry #676

Open
kamieniarz opened this issue Feb 18, 2022 · 4 comments
Open

Changing settings in reactmap duplicates entry #676

kamieniarz opened this issue Feb 18, 2022 · 4 comments

Comments

@kamieniarz
Copy link
Contributor

kamieniarz commented Feb 18, 2022

This is what I have:
image
When I edit this tracking and remove cap by example, entry doesn't get modified but duplicates original one with changes:
image

I tried that with single mons and looks like this issue also affects them. Issue doesn't only affect cap, rank also and proly more.

This issue affects reactmap only. Poracleweb is fine. TurtleSocks claims it's not rm issue: WatWowMap/ReactMap#399 (comment)

@TurtIeSocks
Copy link
Contributor

"claims" I think you are misunderstanding the fundamental differences between ReactMap and PoracleWeb.

PoracleWeb interacts directly with the Poracle db, it grabs some basic config settings from Poracle but otherwise it has all of the logic to run independently.

ReactMap simply sends JSON payloads to Poracle's API endpoints for processing, then Poracle handles the db connection. It has relatively little logic, it's just a UI layer for interacting with Poracle, not Poracle's db.

@jfberry
Copy link
Collaborator

jfberry commented Feb 20, 2022

When a user selects edit are you presenting as a new row, or using the edit row functionality on the monster api? @TurtIeSocks
@kamieniarz a reproduction api call sequence would help

@kamieniarz
Copy link
Contributor Author

@jfberry here is how it goes:

  1. Open poracle menu in reactmap
  2. Open mons tab
  3. Select 'edit' option for existing entry
  4. Edit settings
  5. Save
  6. Entry that was edited is still there and new one was created with values that match changes that were made

@TurtIeSocks no idea how these things work. That's why I said it works fine in poracleweb but the issue is with reactmap. If that's irrelevant then simply ignore my finding

@jfberry
Copy link
Collaborator

jfberry commented Feb 20, 2022

I don't have up to date reactmap so unable to repro so need api calls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants