Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intrgrate Didem's visualizing image embeddings #1

Open
6 tasks
Ultimate-Storm opened this issue Jan 10, 2023 · 4 comments
Open
6 tasks

Intrgrate Didem's visualizing image embeddings #1

Ultimate-Storm opened this issue Jan 10, 2023 · 4 comments

Comments

@Ultimate-Storm
Copy link
Collaborator

Ultimate-Storm commented Jan 10, 2023

Regarding the visualization pipeline you are developing and gathering, Didem has this repo on the groups' github called visualizing image embeddings: https://github.com/KatherLab/visualizing_image_embeddings. It takes images/tiles and labels (for the purpose of coloring plots according to class). Upon reducing dimensions with t-sne, it plots both a plain scatter plot with dots and a scatter plot with the images on the place of images instead of dots.

  • add proper readme for this project
  • made it a proper python package
  • format input arguments
  • add example output images
  • store model ckpt elsewhere
  • test on Marko's cohort and evaluate the results
@dcifci
Copy link

dcifci commented Jan 16, 2023

What can be improved in visualizing_feature_embeddings:

  • implement RetCCL feature extraction, remove the existing SSL model
  • Feature extraction must be done on batches
  • Feature extraction code is unnecessarily modular, which makes things more complicated and harder to debug (sorry about that!)
  • Two plots are plotted with different libraries: make them compatible
  • In the thumbnail plotting, image size must be adjustable by the user so that one should not go over the source code every time. We can't decide on thumbnail size automatically. The solution I can recommend is that feature extraction and clustering/plotting must be two different steps.
  • give more more user-defined options for plotting (advanced task:))

@dcifci
Copy link

dcifci commented Jan 16, 2023

Sample input and output added, and readme is updated. Readme could be more detailed, but it makes more sense to do it here in wanshi utils.

@dcifci
Copy link

dcifci commented Jan 16, 2023

  • correct dot plot legends for showing actual names

@dcifci
Copy link

dcifci commented Jan 17, 2023

  • create a unique name for each run, maybe with user input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants