Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReplicaCall/RouterCallImpl: do not retry on every error #66

Closed
nurzhan-saktaganov opened this issue Sep 13, 2024 · 0 comments · Fixed by #76
Closed

ReplicaCall/RouterCallImpl: do not retry on every error #66

nurzhan-saktaganov opened this issue Sep 13, 2024 · 0 comments · Fixed by #76
Labels
enhancement New feature or request invalid This doesn't seem right performance

Comments

@nurzhan-saktaganov
Copy link
Collaborator

ReplicaCall and RouterCallImpl always retry regardless of the error type.
I guess, retrying on StorageCallAssertError or some other error is not effective,
because it is highly likely to get the same result in the second and so on retries.

So, I propose retrying only in the case of StorageCallVShardError.
@nurzhan-saktaganov nurzhan-saktaganov added enhancement New feature or request invalid This doesn't seem right performance labels Sep 13, 2024
nurzhan-saktaganov added a commit that referenced this issue Sep 17, 2024
@nurzhan-saktaganov
resolve issue #66
0ff96ae 
* retry tarantool request only on some vshard errors
* do not support anymore StorageCallAssertError, BucketStatError (we don't use it, clients also shouldn't)
* do not export anymore storageCallVShardError (clients should not handle it manually)
@nurzhan-saktaganov nurzhan-saktaganov mentioned this issue Sep 17, 2024
Merged
nurzhan-saktaganov added a commit that referenced this issue Sep 17, 2024
@nurzhan-saktaganov
resolve issue #66
3e24def 
* retry tarantool request only on some vshard errors
* do not support anymore StorageCallAssertError, BucketStatError (we don't use it, clients also shouldn't)
* do not export anymore storageCallVShardError (clients should not handle it manually)
nurzhan-saktaganov added a commit that referenced this issue Sep 17, 2024
@nurzhan-saktaganov
resolve issue #66
ca6227b 
* retry tarantool request only on some vshard errors
* do not support anymore StorageCallAssertError, BucketStatError (we don't use it, clients also shouldn't)
* do not export anymore storageCallVShardError (clients should not handle it manually)
nurzhan-saktaganov added a commit that referenced this issue Sep 18, 2024
@nurzhan-saktaganov
resolve issue #66
ee6e74c 
* retry tarantool request only on some vshard errors
* do not support anymore StorageCallAssertError, BucketStatError (we don't use it, clients also shouldn't)
nurzhan-saktaganov added a commit that referenced this issue Sep 20, 2024
@nurzhan-saktaganov
resolve issue #66
8f07c87 
* retry tarantool request only on some vshard errors
* do not export anymore storageCallAssertError, bucketStatError
nurzhan-saktaganov added a commit that referenced this issue Sep 20, 2024
@nurzhan-saktaganov
resolve issue #66
e322876 
* retry tarantool request only on some vshard errors
* do not export anymore storageCallAssertError, bucketStatError
nurzhan-saktaganov added a commit that referenced this issue Sep 20, 2024
@nurzhan-saktaganov
resolve issue #66
dbe6a1e 
* retry tarantool request only on some vshard errors
* do not export anymore storageCallAssertError, bucketStatError
nurzhan-saktaganov added a commit that referenced this issue Sep 21, 2024
@nurzhan-saktaganov
resolve issue #66
b22112f 
* retry tarantool request only on some vshard errors
* do not export anymore storageCallAssertError, bucketStatError
KaymeKaydex pushed a commit that referenced this issue Sep 23, 2024
@nurzhan-saktaganov
resolve issue #66 (#76)
0eda4e0 
* retry tarantool request only on some vshard errors
* do not export anymore storageCallAssertError, bucketStatError
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request invalid This doesn't seem right performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

resolve issue #66 KaymeKaydex/go-vshard-router
1 participant
@nurzhan-saktaganov