Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align with browser's <datalist> #166

Closed
1 of 3 tasks
shrpne opened this issue Oct 3, 2019 · 5 comments
Closed
1 of 3 tasks

Align with browser's <datalist> #166

shrpne opened this issue Oct 3, 2019 · 5 comments
Labels
hacktoberfest This issue is participating in hacktoberfest help wanted Extra attention is needed minor This is a thing to include in the next minor release
Milestone
1.10

Comments

@shrpne
Copy link
Contributor

shrpne commented Oct 3, 2019

I'm submitting a ...

  • bug report
  • feature request
  • support request

What is the expected behavior?

Align VSS features and default options with browser's <datalist> implementation

  • Behavior when you press Enter on VSS with opened/closed dropdown
  • Allow open suggestions list with Up,Down buttons
  • Tab with a hovered item should also select this item

What is the motivation / use case for changing the behavior?

  • Browsers implement datalist based on the W3C specification which supposed to have high-quality UX, so this implementation can be considered as best practice
  • If all implementations of autocomplete will have the same UX, then it will be easier for users to use them, because they will get used to the common behavior.

Please tell us about your environment:

  • Vue-simple-suggest version: 1.9.5
  • Browser: all
  • Language: all
  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
@Raiondesu
Copy link
Contributor

Hello, @shrpne. :)
Nice to see you again.

Thank you for this request, it makes sense for all autocompletes to have the same basic ux.

We are, however, unable to implement this ourselves due to time constraints, so a PR would be very welcome.

This would be a major-minor change, depending on which parts of API are changed.

@Raiondesu Raiondesu added hacktoberfest This issue is participating in hacktoberfest help wanted Extra attention is needed labels Oct 3, 2019
@Raiondesu Raiondesu added the minor This is a thing to include in the next minor release label Oct 3, 2019
@shrpne
Copy link
Contributor Author

shrpne commented Oct 3, 2019

Great that you like it, I'll try to make it and split to several small PRs

This was referenced Oct 5, 2019
Merged
Merged
@Raiondesu Raiondesu added this to the 1.10 milestone Oct 7, 2019
@Raiondesu
Copy link
Contributor

@allcontributors-bot add @shrpne for ideas

@allcontributors allcontributors bot mentioned this issue Oct 7, 2019
Merged
@allcontributors
Copy link
Contributor

@Raiondesu

I've put up a pull request to add @shrpne! 🎉

@shrpne shrpne mentioned this issue Oct 7, 2019
Merged
2 tasks
@Raiondesu
Copy link
Contributor

Raiondesu commented Oct 9, 2019 •
edited
Loading

Done in #175, #176 and #184.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hacktoberfest This issue is participating in hacktoberfest help wanted Extra attention is needed minor This is a thing to include in the next minor release
Projects
None yet
Milestone
1.10
Development

No branches or pull requests
2 participants
@shrpne @Raiondesu