[Feature Request]: Add GDAP Roles Viva Goals Administrator and Viva Pulse Administrator

[peter-fisher]

Description of the new feature - must be an in-depth explanation of the feature you want, reasoning why, and the added benefits for MSPs as a whole.

Noticed that Viva Goals Administrator and Viva Pulse Administrator roles were missing from the GDAP options. I just added them to the two JSON files in my repo and it seems to work fine.

Here is the updated JSON file -
GDAPRoles.json

PowerShell commands you would normally use to achieve above request

No response

[MWGMorningwood]

Why not make a PR to dev?

[peter-fisher]

Why not make a PR to dev?

I've never contributed before and the CIPP docs say to create an issue first. I'm also not well-versed in making pull requests to be honest. When I attempted the PR, it looked like it was going to also include a commit for the github workflow yml file and I didn't know how to take that out.

[MWGMorningwood]

Check out https://docs.cipp.app/dev-documentation/cipp-dev-guide/setting-up-for-local-development
.gitignore is how you'd exclude specific files, but making a local dev env solves the problem indirectly.

[peter-fisher]

Check out https://docs.cipp.app/dev-documentation/cipp-dev-guide/setting-up-for-local-development .gitignore is how you'd exclude specific files, but making a local dev env solves the problem indirectly.

Thanks. I started that process. For now, it looks like if I just submit the PR from the dev branch instead of main it doesn't include any workflow files so I'll do that now.

[peter-fisher]

I would like to work on this please!

[github-actions]

Great! I assigned you (@peter-fisher) to the issue. Have fun working on it!