Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing "Tenant Mode" selector in SuperAdmin Settings #2767

Closed
jdr8 opened this issue Aug 4, 2024 · 6 comments
Closed

Missing "Tenant Mode" selector in SuperAdmin Settings #2767

jdr8 opened this issue Aug 4, 2024 · 6 comments
Labels
bug Something isn't working unconfirmed-by-user

Comments

@jdr8
Copy link
Contributor

jdr8 commented Aug 4, 2024

Description

In the SuperAdmin Settings tab of Application Settings, Tenant Mode does not allow you to select an option.

  1. Click on "CIPP -> Application Settings" as a superadmin user
  2. Navigate to the SuperAdmin Settings tab (visible when logged in as superadmin)
  3. When loading completes - no option to select a tenant mode.
    image

Non-sponsored instance front end version 6.2.0 backend version 6.2.0
All caches cleared, different browser tested, "incognito" tested.
Re-sign in tested.

Inspected elements, noticed nothing renders for a drop down or selection box, and no errors in console for this to not be appearing.

I can see the network response of ExecPartnerMode?Action=ListCurrent responds with TenantMode: "default", but there is no component rendering.

@jdr8 jdr8 added bug Something isn't working unconfirmed-by-user labels Aug 4, 2024
Copy link

github-actions bot commented Aug 4, 2024

Thank you for creating a bug. Please make sure your bug is indeed a unique case by checking current and past issues, and reading the complete documentation at https://docs.cipp.app/
If your bug is a known documentation issue, it will be closed without notice by a contributor. To confirm that this is not a bug found in the documentation, please copy and paste the following comment: "I confirm that I have checked the documentation thoroughly and believe this to be an actual bug."

Without confirming, your report will be closed in 24 hours. If you'd like this bug to be assigned to you, please comment "I would like to work on this please!".

@jdr8
Copy link
Contributor Author

jdr8 commented Aug 4, 2024

I confirm that I have checked the documentation thoroughly and believe this to be an actual bug

@ccalbreath
Copy link

I confirm that I have checked the documentation thoroughly and believe this to be an actual bug.

@lismorediocese
Copy link

I am also having this issue

@jdr8
Copy link
Contributor Author

jdr8 commented Aug 5, 2024

Looks like the following is missing from src/views/cipp/app-settings/SettingsSuperAdmin.jsx after line 68:

            <CRow>
              <CCol sm={12} md={12} className="mb-3">
                <p className="fw-lighter">Tenant Mode</p>
                <Form
                  onSubmit={onSubmit}
                  initialValues={partnerConfig.data}
                  render={({ handleSubmit }) => (
                    <>
                      {partnerConfig.isFetching && <CSpinner size="sm" className="me-2" />}
                      <CForm id="submitForm" onSubmit={handleSubmit}>
                        <RFFCFormRadio
                          name="TenantMode"
                          label="Multi Tenant - GDAP Mode"
                          value="default"
                        />
                        <RFFCFormRadio
                          name="TenantMode"
                          label="Multi Tenant - Add Partner Tenant"
                          value="PartnerTenantAvailable"
                        />
                        <RFFCFormRadio
                          name="TenantMode"
                          label="Single Tenant - Own Tenant Mode"
                          value="owntenant"
                        />
                      </CForm>
                    </>
                  )}
                />
                {webhookCreateResult.isSuccess && (
                  <CippCallout color="info" dismissible>
                    {webhookCreateResult?.data?.results}
                  </CippCallout>
                )}
              </CCol>
            </CRow>

This is now working for me after manually adding this back

@KelvinTegelaar
Copy link
Owner

Fixed in dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working unconfirmed-by-user
Projects
None yet
Development

No branches or pull requests

4 participants