Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhaBOX release via bioconda #25

Closed
bernt-matthias opened this issue Sep 16, 2024 · 10 comments
Closed

PhaBOX release via bioconda #25

bernt-matthias opened this issue Sep 16, 2024 · 10 comments

Comments

@bernt-matthias
Copy link

I'm currently working on a release of phabox via bioconda.

Was wondering why the title of the current release contains the text " V1.1" but the link 0.1.0 (plus beta): https://github.com/KennthShang/PhaBOX/releases/tag/v0.1.0-beta.

Would you consider this release as beta? Maybe then it would be better to stick with https://github.com/KennthShang/PhaTYP?

@bernt-matthias
Copy link
Author

Made some progress here: bioconda/bioconda-recipes#50753

Contains some updates to the setup.py and imports that you might want to include here.

@KennthShang
Copy link
Owner

Hi there,

Thanks for the effort! I have removed the v1.1 release. The v1.1 is for the module conflict and I have revised the codes so that the problem will no longer occur.

Best,
Jiayu

@bernt-matthias
Copy link
Author

Thanks for the reply. Can you just make a new release? A release (with version) is needed for bioconda.
As a comment: try to avoid to remove releases, people might refer to them, e.g. in publications.

@KennthShang
Copy link
Owner

Thanks for your suggestions. I will keep it in mind :)

Best,
Jiayu

@bernt-matthias
Copy link
Author

FYI: A first version of phabox (version 2.0) is now in bioconda bioconda/bioconda-recipes#50753

@KennthShang
Copy link
Owner

Hi, I found the recipes via the bioconda cannot correctly run PhaBOX 2. Because there is a large different between versions 1 and 2

Maybe you can use the latest meta.yaml and pyproject.toml in our GitHub folder to replace them?

Best,
Jiayu

@bernt-matthias
Copy link
Author

Dear @KennthShang I could work on this. Could you give me more information what does not work / what should be adapted?

Which of the two files would be the source of truth:

Note that you might also directly open PRs for the bioconda recipe on your own - you can ping me anytime.

Instead of the meta.yaml and phabox2.yaml in this repo (which you probably have for reproducibility) you could use the docker containers which are automatically built for every bioconda recipe: https://quay.io/repository/biocontainers/phabox?tab=info.

@KennthShang
Copy link
Owner

Hi @bernt-matthias

The meta.yaml is the receipt I used for conda build (or mamba build). Same format as the bioconda receipt I suppose.

Also, I built the latest Phabox package, which is available via my personal channel (as mentioned in the current WIKI).

When I tried the release via bioconda channel, some modules were not available, and I suppose they are the following ones:

  • Kcounter -c bioconda (Used in contamination)
  • prodigal-gv -c bioconda (Used to replace the prodigal version in phabox2, since currently it is generalized for all viruses
  • mafft -c bioconda (Used for marker genes MSA
  • fasttree -c bioconda (Used for phylogenetic tree construction
  • seaborn -c conda-forge (Used for sub-network visualization)

Thank you very much for your valuable suggestions :). We are still maintaining our phabox webserver and other issues. I will try to release a docker container once we fix them all.

(I would like to pin this issue if you would not mind.

Best,
Jiayu

@KennthShang KennthShang pinned this issue Oct 24, 2024
@bernt-matthias
Copy link
Author

I opened a PR updating to 2.1 and adding the missing requirements

@KennthShang
Copy link
Owner

Good to know. I will try to update the receipt myself once I figure out the process. Many thanks for your guidance!

Best,
Jiayu

@KennthShang KennthShang unpinned this issue Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants