Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect toolbar min-height after changing Mantine theme scale #431

Open
1 task done
taurusnova opened this issue Oct 30, 2024 · 0 comments
Open
1 task done

Incorrect toolbar min-height after changing Mantine theme scale #431

taurusnova opened this issue Oct 30, 2024 · 0 comments
Labels
bug Something isn't working V2 Issue with MRT V2

Comments

@taurusnova
Copy link

mantine-react-table version

2.0.0-beta.6

react & react-dom versions

18.2.0

Describe the bug and the steps to reproduce it

If you apply a custom Mantine theme that overrides the scale field you'll observe that the toolbars in the Mantine table do not have the proper min-height.

The min-height for toolbars is hardcoded to 3.5 rem (see code), but it should dynamically scale based on the Mantine theme scale, see example.

Minimal, Reproducible Example - (Optional, but Recommended)

https://codesandbox.io/p/sandbox/simple-mantine-react-table-forked-3fsjkp?file=%2Fsrc%2FApp.js

Screenshots or Videos (Optional)

No response

Do you intend to try to help solve this bug with your own PR?

None

Terms

  • I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
@alessandrojcm alessandrojcm added bug Something isn't working V2 Issue with MRT V2 labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working V2 Issue with MRT V2
Projects
None yet
Development

No branches or pull requests

2 participants