Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images in /docs/README.md really big; suggesting embedding thumbnails and linking to full size image. #89

Open
dreirund opened this issue Mar 30, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@dreirund
Copy link

The images shown within /blob/master/docs/README.md (this is linked from the main README.md/ "main page" when one navigates the browser to github.com/BenRoe/awesome-mechanical-keyboard) are quite big and "kill" my 1Mbit/s internet connection, often aborting by timeout before everything is loaded.

I suggest that only thumbnails are shown within the file, and the thumbnails link to the full sized image, e.g. in markdown-syntax embedding like the following is used:

[![image](http://example.com/image-thumb.jpg "image")](http://example.com/image.jpg)
@dreirund
Copy link
Author

Addendum: This would also save general internet traffic, thus being part of saving for the need to increase more and more the capacity of datacenters, and it would provide more technical-barrier-free access to the list for people who do not have fast internet.

@BenRoe
Copy link
Collaborator

BenRoe commented Apr 18, 2021

I am aware of this problem, but i don't have the time to fix it.
The project use the remote images. so no thumbnails available.

Solution:
Download the remote images and create thumbnails during the build process with Gridsome. Then replace the big images with thumbnails and link it to the big images.

I am thinking to switch to Gatsby. With Gatsby it easier to implement this feature.

@BenRoe BenRoe added the enhancement New feature or request label Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants