Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycodes for Space Cadet Keys seems wrong in Docs or Launcher (Keychron Q3 HE) #327

Open
drandarov-io opened this issue Nov 14, 2024 · 3 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@drandarov-io
Copy link

Issue Description

https://docs.qmk.fm/keycodes describes the space cadet keycodes as starting with SC_ , however inside https://launcher.keychron.com/#/keymap the keycodes they start with KC_.

This caused me quite a bit of confusion until I went over every single key in the launcher since the codes from the docs didn't work.
Not sure if this is a general issue or just with the Q3 HE.

image

image

@drandarov-io drandarov-io added help wanted Extra attention is needed question Further information is requested labels Nov 14, 2024
@drandarov-io drandarov-io changed the title Keycodes for Space Cadet Keys seems wrong (Keychron Q3 HE) Keycodes for Space Cadet Keys seems wrong in Docs or Launcher (Keychron Q3 HE) Nov 14, 2024
@PeterMortensen
Copy link

PeterMortensen commented Nov 15, 2024

The Via clone is, well, a clone of Via, so what did you expect? Yes, that is a rhetorical question (mostly).

That is in KEYMAPSPECIAL"LS(" (about 15% down in the list). Keycode: KC_LSPO. From the documentation: SC_LSPO

@PeterMortensen
Copy link

PeterMortensen commented Nov 15, 2024

An initial guess would be that some renaming happened in QMK, e.g., like for some keycodes for mouse actions (2024-07-03). And Via wasn't updated. And the Via clone is, well, a clone of Via.

The keycodes documentation page (that includes the space-cadet keycodes) is docs/keycodes.md.

Search (Bash) in the main QMK repository, default branch:

# -i   : Case insensitive. Alternative: --regexp-ignore-case
# -S   : 'Pickaxe'
# --all: In all branches
#
git log -i -S"space"  --  docs/keycodes.md | grep -i cadet

One of the hits is Normalise Space Cadet keycodes (numero 18864. 2022-10-27):

KC_LSPO -> SC_LSPO etc.
KC_SFTENT -> SC_SENT

Conclusion

The keycodes aren't wrong per se, only their names, renamed on 2022-10-27. The confusion is caused by the constant renaming in QMK (and no mention of it in the QMK documentation); and related software, documentation, and guides not being updated in a timely manner. For the Vial fangirls/fanboys, the Vial client (the latest release, 0.7.1) hasn't been updated either (they are in "Keymap"Quantum. For example, "LS (", hover text "KC_LSPO: Left Shift when held, ( when tapped". After assignment, it is (double clicking on the assigned key) "KC_LSPO. Computed value: 0x7C1A").

It affects not only the Q3 HE, but the whole QMK ecosystem.

@lokher
Copy link
Member

lokher commented Nov 29, 2024

It's fixed now, thank you for pointing it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants