Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new StringValueStore supporting compression #104

Open
hendrikmuhs opened this issue Sep 13, 2018 · 0 comments
Open

Implement new StringValueStore supporting compression #104

hendrikmuhs opened this issue Sep 13, 2018 · 0 comments
Assignees

Comments

@hendrikmuhs
Copy link
Contributor

Followup of #69

The StringValueStore should be re-implemented to reuse the same techniques as todays JsonValueStore which is supporting compression and using length-prefixes instead of zero-termination.

To ensure backwards compatibility rename StringValueStore to StringValueStoreDeprecated, add a new StringValueStore using a new enum value for the type. While writer and mergers can be deleted the reader must be kept to support existing keyvi files at least until the next bigger release.

The new StringValueStore and the JsonValueStore should only differ by 2 operations: encoding and decoding json, everything else should be almost identical.

@amit-cliqz amit-cliqz self-assigned this Sep 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants