-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use insertRule instead of appendChild in production #115
Comments
Perhaps see #83? |
Ah! That's right, totally forgot about that PR 👍 cc @threepointone, see #83 |
Closing as this is already tracked in #76 |
Don't forget the tradeoff, you wouldn't want to use this in dev. Cheers all! |
@threepointone What do you mean when you say that the styles aren't editable? Like, you can't edit them in the style inspector, or you can't edit the contents of the style sheet? |
The former; this is the main caveat with this method. https://bugs.chromium.org/p/chromium/issues/detail?id=387952#c6 |
Dunno if you folks have made any progress on this, but thought this might help. I extracted just the 'stylesheet' parts of glamor into a generic module. It handles using |
So check this out:
Based on @threepointone's experience, I suggest that we explore the possibility of doing this. Mostly because of this:
Thoughts? 💭
The text was updated successfully, but these errors were encountered: