-
Notifications
You must be signed in to change notification settings - Fork 75
Convert suppression comments #207
Comments
@jtbandes fixing the comment positioning issue will be important for this this work right. |
Flow now supports having multiple line comment suppressions for a single expression, e.g.
When handling situations like this we'll probably want to merge these into a single comment, e.g.
I think we can drop |
There may be text after the error code, e.g.
If we're merging multiple comments like this we'll need to figure out a good pattern for doing so. |
It looks like |
Shouldn't suppressions be stripped as they might be completely different or not needed in TS? :) |
@meandmax that's a good point. If we strip out all of the flow suppressions it would be good to have a way to automatically add TypeScript suppressions in to the generated code. I wonder if there's tooling out there that already does this. |
Closing in preference of #284. |
e.g.
There is no
@ts-fix-me
, see microsoft/TypeScript#28796The text was updated successfully, but these errors were encountered: