Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify jointParents value for root bones in XR_FB_hand_tracking_mesh #154

Open
flashk opened this issue Jun 10, 2023 · 4 comments
Open
Labels
clarification Reflects a spec clarification request synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab vendor-extension

Comments

@flashk
Copy link

flashk commented Jun 10, 2023

I'm adding support for the XR_FB_hand_tracking_mesh extension to my application, and it wasn't clear to me what the jointParents value of the XrHandTrackingMeshFB struct would be for root bones. Based on my testing it appears the joint parent value for root bones is XR_HAND_JOINT_MAX_ENUM_EXT. I think it would be useful to clarify that in the specification.

@rpavlik
Copy link
Contributor

rpavlik commented Jun 14, 2023

Hmm, MAX_ENUM shouldn't actually be used anywhere, it solely exists to force the size of an enum type due to annoying limitations of C. I'll see if I can ping somebody who can answer this.

@rpavlik rpavlik added clarification Reflects a spec clarification request vendor-extension labels Jun 14, 2023
@rpavlik-bot rpavlik-bot added the synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab label Jun 21, 2023
@rpavlik-bot
Copy link
Collaborator

An issue (number 2038) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2038 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

@RobertC-Meta
Copy link

I'm adding support for the XR_FB_hand_tracking_mesh extension to my application, and it wasn't clear to me what the jointParents value of the XrHandTrackingMeshFB struct would be for root bones. Based on my testing it appears the joint parent value for root bones is XR_HAND_JOINT_MAX_ENUM_EXT. I think it would be useful to clarify that in the specification.

Sorry for the delay on this. I have confirmed that the this is the way that the extension is intended to work (returning XR_HAND_JOINT_MAX_ENUM_EXT for the parent of the wrist joint). I will update the documentation to reflect this. It would likely cause more problems to change it.

@flashk
Copy link
Author

flashk commented Jul 20, 2023

Great, thanks for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clarification Reflects a spec clarification request synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab vendor-extension
Projects
None yet
Development

No branches or pull requests

4 participants