Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification Request: XR_BD_controller_interaction rev 2 #158

Open
amini-allight opened this issue Sep 26, 2023 · 3 comments
Open

Clarification Request: XR_BD_controller_interaction rev 2 #158

amini-allight opened this issue Sep 26, 2023 · 3 comments
Labels
synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab vendor-extension

Comments

@amini-allight
Copy link

For the new Pico G3 bindings in the XR_BD_controller_interaction extension the thumbstick path is listed as simply:

.../input/thumbstick

Whereas all other thumbsticks in OpenXR are:

.../input/thumbstick/x
.../input/thumbstick/y

Is this a mistake or meant to indicate some different functionality of the thumbstick action? The summary of input types here seems to suggest thumbsticks should always have x and y components.

@rpavlik
Copy link
Contributor

rpavlik commented Sep 26, 2023

I believe your interpretation is correct. (I thought I had removed the bare /thumbstick and left only the /thumbstick/x and /thumbstick/y during the editing process...) If you look at the XML version, it's shown as a vec2f: https://github.com/KhronosGroup/OpenXR-Docs/blob/main/specification/registry/xr.xml#L6282

I will check with the vendor to verify.

@junyan-pico
Copy link

Thanks @amini-allight for reporting the issue and @rpavlik for helping respond. I confirmed with my colleagues, the spec was supposed to include those two components for G3 controller:

.../input/thumbstick/x
.../input/thumbstick/y

and our PICO OpenXR runtime already supported them so you should be able to use the two paths with no problem. We will send a change to fix the spec language.

@rpavlik-bot rpavlik-bot added the synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab label Oct 4, 2023
@rpavlik-bot
Copy link
Collaborator

An issue (number 2102) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2102 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab vendor-extension
Projects
None yet
Development

No branches or pull requests

4 participants