Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common handle requirement missing for nested structs #174

Open
Timbals opened this issue Jul 24, 2024 · 1 comment
Open

Common handle requirement missing for nested structs #174

Timbals opened this issue Jul 24, 2024 · 1 comment
Labels
synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab

Comments

@Timbals
Copy link

Timbals commented Jul 24, 2024

In the Valid Usage (Implicit) of XrCompositionLayerCubeKHR it says "Both of space and swapchain must have been created, allocated, or retrieved from the same XrSession"

But for the other types of composition layers, this validity requirement is missing.
This seems like an oversight.

This is presumably because the handles in the other layers are not contained in the layer struct directly, but in a different (nested) struct.
E.g. XrCompositionLayerProjection contains pointers to potentially multiple XrCompositionLayerProjectionViews which contain a XrSwapchainSubImage which contains a swapchain.
I haven't checked if there are structs other than the composition layers that are affected by this.

The validity requirement is generated here but it only seems to check handles that are directly in the struct.

@rpavlik-bot rpavlik-bot added the synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab label Jul 31, 2024
@rpavlik-bot
Copy link
Collaborator

An issue (number 2335) has been filed to correspond to this issue in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2335 ), to facilitate working group processes.

This GitHub issue will continue to be the main site of discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab
Projects
None yet
Development

No branches or pull requests

2 participants