Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Begin/EndFrame session parameter missing from list of externally synchronized parameters #23

Closed
Ralith opened this issue Jul 30, 2019 · 6 comments
Closed

Begin/EndFrame session parameter missing from list of externally synchronized parameters #23

Ralith opened this issue Jul 30, 2019 · 6 comments
Assignees
@rpavlik
Labels
bug Something isn't working synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab

Comments

@Ralith
Copy link
Contributor

Ralith commented Jul 30, 2019

10.4 states:

While xrBeginFrame and xrEndFrame do not need to be called on the same thread, the application must handle synchronization if they are called on separate threads.

However, there is no "Thread Safety" block associated with either function, and section 2.3 does not mention them. The required behavior is clear, but should probably be cross-referenced for ease of discoverability like the other cases.
@rpavlik rpavlik added the bug Something isn't working label Jul 30, 2019
@rpavlik
Copy link
Contributor

rpavlik commented Sep 5, 2019

This is being tracked internally at https://gitlab.khronos.org/openxr/openxr/issues/1216

@rpavlik rpavlik added the synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab label Sep 5, 2019
@rpavlik-bot
Copy link
Collaborator

An issue (number 1216) has been filed to correspond to this issue in the internal Khronos GitLab.

If you have a Khronos account, you can access that issue at KHR:openxr/openxr#1216.

1 similar comment
@rpavlik-bot
Copy link
Collaborator

An issue (number 1216) has been filed to correspond to this issue in the internal Khronos GitLab.

If you have a Khronos account, you can access that issue at KHR:openxr/openxr#1216.

@rpavlik
Copy link
Contributor

rpavlik commented Jan 7, 2022

We have improved our description of this, but apparently I never put it in the XML yet.

@rpavlik rpavlik self-assigned this Jan 7, 2022
@rpavlik
Copy link
Contributor

rpavlik commented Jan 7, 2022

OK, I have an internal MR for this up.

@rpavlik
Copy link
Contributor

rpavlik commented May 28, 2022

Fixed in 1.0.23. Thanks for the report!

@rpavlik rpavlik closed this as completed May 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rpavlik rpavlik

Labels
bug Something isn't working synced to gitlab A corresponding issue has been filed in the Khronos internal GitLab
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rpavlik @Ralith @rpavlik-bot