Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MSL Unbound buffer arrays don't emit spvDescriptor definition #2384

Closed
fatkas opened this issue Oct 4, 2024 · 0 comments · Fixed by #2390
Closed

MSL Unbound buffer arrays don't emit spvDescriptor definition #2384

fatkas opened this issue Oct 4, 2024 · 0 comments · Fixed by #2390

Comments

@fatkas
Copy link
Contributor

fatkas commented Oct 4, 2024

it seems both texture and sampler unbound arrays have

add_spv_func_and_recompile(SPVFuncImplVariableDescriptor); add_spv_func_and_recompile(SPVFuncImplVariableDescriptorArray);

while buffers only have

if (is_var_runtime_size_array(var)) { add_spv_func_and_recompile(SPVFuncImplVariableDescriptorArray);

adding the add_spv_func_and_recompile(SPVFuncImplVariableDescriptor); part fixes it for me locally

don't have minimal source repro handy but can come up with something if needed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MSL: Fix emission of bindless helper template for bindless SSBO. KhronosGroup/SPIRV-Cross
1 participant
@fatkas