Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IntegerFunctions2INTEL has extra dependency on Shader #480

Closed
bashbaug opened this issue Jan 27, 2025 · 0 comments · Fixed by #481
Closed

IntegerFunctions2INTEL has extra dependency on Shader #480

bashbaug opened this issue Jan 27, 2025 · 0 comments · Fixed by #481

Comments

@bashbaug
Copy link
Contributor

bashbaug commented Jan 27, 2025

According to the SPV_INTEL_shader_integer_functions2 specification, the IntegerFunctions2INTEL capability added by this extension should not depend on any other capabilities, but in the SPIR-V grammar file there is an implicit dependency on Shader:

{
"enumerant" : "IntegerFunctions2INTEL",
"value" : 5584,
"capabilities" : [ "Shader" ],
"extensions" : [ "SPV_INTEL_shader_integer_functions2" ],
"version" : "None"
},

We should fix this inconsistency. Because I don't see anything in the descriptions of these instructions that would make them Shader specific I would prefer to update the grammar file vs. updating the spec, but either is possible.

CC: @ianromanick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant