-
Notifications
You must be signed in to change notification settings - Fork 305
/
Copy pathvktImageLoadStoreTests.cpp
3962 lines (3298 loc) · 189 KB
/
vktImageLoadStoreTests.cpp
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*------------------------------------------------------------------------
* Vulkan Conformance Tests
* ------------------------
*
* Copyright (c) 2016 The Khronos Group Inc.
* Copyright (c) 2016 The Android Open Source Project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
*//*!
* \file
* \brief Image load/store Tests
*//*--------------------------------------------------------------------*/
#include "vktImageLoadStoreTests.hpp"
#include "vktTestCaseUtil.hpp"
#include "vktImageTestsUtil.hpp"
#include "vktImageLoadStoreUtil.hpp"
#include "vktImageTexture.hpp"
#include "vkDefs.hpp"
#include "vkRef.hpp"
#include "vkRefUtil.hpp"
#include "vkPlatform.hpp"
#include "vkPrograms.hpp"
#include "vkMemUtil.hpp"
#include "vkBarrierUtil.hpp"
#include "vkBuilderUtil.hpp"
#include "vkQueryUtil.hpp"
#include "vkImageUtil.hpp"
#include "vkCmdUtil.hpp"
#include "vkObjUtil.hpp"
#include "vkBufferWithMemory.hpp"
#include "deMath.h"
#include "deUniquePtr.hpp"
#include "deSharedPtr.hpp"
#include "deStringUtil.hpp"
#include "tcuImageCompare.hpp"
#include "tcuTexture.hpp"
#include "tcuTextureUtil.hpp"
#include "tcuFloat.hpp"
#include "tcuFloatFormat.hpp"
#include "tcuStringTemplate.hpp"
#include "tcuVectorUtil.hpp"
#include <string>
#include <vector>
#include <map>
using namespace vk;
namespace vkt
{
namespace image
{
namespace
{
enum DeviceScopeType
{
DEVICESCOPE_NONE,
DEVICESCOPE_STORE,
DEVICESCOPE_LOAD
};
enum TestConfigurationType
{
TC_NONE,
TC_COMP_COMP,
TC_COMP_DRAW
};
// Check for three-component (non-packed) format, i.e. pixel size is a multiple of 3.
bool formatHasThreeComponents(VkFormat format)
{
const tcu::TextureFormat texFormat = mapVkFormat(format);
return (getPixelSize(texFormat) % 3) == 0;
}
VkFormat getSingleComponentFormat(VkFormat format)
{
tcu::TextureFormat texFormat = mapVkFormat(format);
texFormat = tcu::TextureFormat(tcu::TextureFormat::R, texFormat.type);
return mapTextureFormat(texFormat);
}
VkImageAspectFlags getImageAspect(VkFormat format)
{
return isDepthStencilFormat(format) ? VK_IMAGE_ASPECT_DEPTH_BIT : VK_IMAGE_ASPECT_COLOR_BIT;
}
inline VkBufferImageCopy makeBufferImageCopy(const Texture &texture)
{
return image::makeBufferImageCopy(makeExtent3D(texture.layerSize()), texture.numLayers());
}
VkBufferImageCopy makeBufferImageCopy(const Texture &texture, const VkImageAspectFlags &aspect)
{
const VkBufferImageCopy copyParams = {
0ull, // VkDeviceSize bufferOffset;
0u, // uint32_t bufferRowLength;
0u, // uint32_t bufferImageHeight;
makeImageSubresourceLayers(aspect, 0u, 0u, texture.numLayers()), // VkImageSubresourceLayers imageSubresource;
makeOffset3D(0, 0, 0), // VkOffset3D imageOffset;
makeExtent3D(texture.layerSize()), // VkExtent3D imageExtent;
};
return copyParams;
}
std::string getShaderImageFormatQualifierStr(const VkFormat &format)
{
VkFormat testFormat;
switch (format)
{
case VK_FORMAT_D16_UNORM:
testFormat = VK_FORMAT_R16_UNORM;
break;
case VK_FORMAT_D32_SFLOAT:
testFormat = VK_FORMAT_R32_SFLOAT;
break;
default:
testFormat = format;
}
return getShaderImageFormatQualifier(mapVkFormat(testFormat));
}
tcu::ConstPixelBufferAccess getLayerOrSlice(const Texture &texture, const tcu::ConstPixelBufferAccess access,
const int layer)
{
switch (texture.type())
{
case IMAGE_TYPE_1D:
case IMAGE_TYPE_2D:
case IMAGE_TYPE_BUFFER:
// Not layered
DE_ASSERT(layer == 0);
return access;
case IMAGE_TYPE_1D_ARRAY:
return tcu::getSubregion(access, 0, layer, access.getWidth(), 1);
case IMAGE_TYPE_2D_ARRAY:
case IMAGE_TYPE_CUBE:
case IMAGE_TYPE_CUBE_ARRAY:
case IMAGE_TYPE_3D: // 3d texture is treated as if depth was the layers
return tcu::getSubregion(access, 0, 0, layer, access.getWidth(), access.getHeight(), 1);
default:
DE_FATAL("Internal test error");
return tcu::ConstPixelBufferAccess();
}
}
//! \return the size in bytes of a given level of a mipmap image, including array layers.
vk::VkDeviceSize getMipmapLevelImageSizeBytes(const Texture &texture, const vk::VkFormat format,
const uint32_t mipmapLevel)
{
tcu::IVec3 size = texture.size(mipmapLevel);
return tcu::getPixelSize(vk::mapVkFormat(format)) * size.x() * size.y() * size.z();
}
//! \return the size in bytes of the whole mipmap image, including all mipmap levels and array layers
vk::VkDeviceSize getMipmapImageTotalSizeBytes(const Texture &texture, const vk::VkFormat format)
{
vk::VkDeviceSize size = 0u;
int32_t levelCount = 0u;
do
{
size += getMipmapLevelImageSizeBytes(texture, format, levelCount);
levelCount++;
} while (levelCount < texture.numMipmapLevels());
return size;
}
//! \return true if all layers match in both pixel buffers
bool comparePixelBuffers(tcu::TestLog &log, const Texture &texture, const VkFormat format,
const tcu::ConstPixelBufferAccess reference, const tcu::ConstPixelBufferAccess result,
const uint32_t mipmapLevel = 0u)
{
DE_ASSERT(reference.getFormat() == result.getFormat());
DE_ASSERT(reference.getSize() == result.getSize());
const bool is3d = (texture.type() == IMAGE_TYPE_3D);
const int numLayersOrSlices = (is3d ? texture.size(mipmapLevel).z() : texture.numLayers());
const int numCubeFaces = 6;
int passedLayers = 0;
for (int layerNdx = 0; layerNdx < numLayersOrSlices; ++layerNdx)
{
const std::string comparisonName = "Comparison" + de::toString(layerNdx);
const std::string comparisonDesc =
"Image Comparison, " + (isCube(texture) ? "face " + de::toString(layerNdx % numCubeFaces) + ", cube " +
de::toString(layerNdx / numCubeFaces) :
is3d ? "slice " + de::toString(layerNdx) :
"layer " + de::toString(layerNdx) + " , level " + de::toString(mipmapLevel));
const tcu::ConstPixelBufferAccess refLayer = getLayerOrSlice(texture, reference, layerNdx);
const tcu::ConstPixelBufferAccess resultLayer = getLayerOrSlice(texture, result, layerNdx);
bool ok = false;
switch (tcu::getTextureChannelClass(mapVkFormat(format).type))
{
case tcu::TEXTURECHANNELCLASS_UNSIGNED_INTEGER:
case tcu::TEXTURECHANNELCLASS_SIGNED_INTEGER:
{
ok = tcu::intThresholdCompare(log, comparisonName.c_str(), comparisonDesc.c_str(), refLayer, resultLayer,
tcu::UVec4(0), tcu::COMPARE_LOG_RESULT);
break;
}
case tcu::TEXTURECHANNELCLASS_UNSIGNED_FIXED_POINT:
{
// Allow error of minimum representable difference
tcu::Vec4 threshold(
1.0f /
((tcu::UVec4(1u) << tcu::getTextureFormatMantissaBitDepth(mapVkFormat(format)).cast<uint32_t>()) - 1u)
.cast<float>());
// Add 1 ULP of fp32 imprecision to account for image comparison fp32 math with unorm->float conversions.
threshold += tcu::Vec4(std::numeric_limits<float>::epsilon());
ok = tcu::floatThresholdCompare(log, comparisonName.c_str(), comparisonDesc.c_str(), refLayer, resultLayer,
threshold, tcu::COMPARE_LOG_RESULT);
break;
}
case tcu::TEXTURECHANNELCLASS_SIGNED_FIXED_POINT:
{
const tcu::UVec4 bitDepth =
tcu::getTextureFormatMantissaBitDepth(mapVkFormat(format)).cast<uint32_t>() - 1u;
// To avoid bit-shifting with negative value, which is undefined behaviour.
const tcu::UVec4 fixedBitDepth =
tcu::select(bitDepth, tcu::UVec4(0u, 0u, 0u, 0u),
tcu::greaterThanEqual(bitDepth.cast<int32_t>(), tcu::IVec4(0, 0, 0, 0)));
// Allow error of minimum representable difference
const tcu::Vec4 threshold(1.0f / ((tcu::UVec4(1u) << fixedBitDepth) - 1u).cast<float>());
ok = tcu::floatThresholdCompare(log, comparisonName.c_str(), comparisonDesc.c_str(), refLayer, resultLayer,
threshold, tcu::COMPARE_LOG_RESULT);
break;
}
case tcu::TEXTURECHANNELCLASS_FLOATING_POINT:
{
// Convert target format ulps to float ulps and allow 1 ulp difference
const tcu::UVec4 threshold(
tcu::UVec4(1u) << (tcu::UVec4(23) -
tcu::getTextureFormatMantissaBitDepth(mapVkFormat(format)).cast<uint32_t>()));
ok = tcu::floatUlpThresholdCompare(log, comparisonName.c_str(), comparisonDesc.c_str(), refLayer,
resultLayer, threshold, tcu::COMPARE_LOG_RESULT);
break;
}
default:
DE_FATAL("Unknown channel class");
}
if (ok)
++passedLayers;
}
return passedLayers == numLayersOrSlices;
}
//!< Zero out invalid pixels in the image (denormalized, infinite, NaN values)
void replaceBadFloatReinterpretValues(const tcu::PixelBufferAccess access)
{
DE_ASSERT(tcu::getTextureChannelClass(access.getFormat().type) == tcu::TEXTURECHANNELCLASS_FLOATING_POINT);
for (int z = 0; z < access.getDepth(); ++z)
for (int y = 0; y < access.getHeight(); ++y)
for (int x = 0; x < access.getWidth(); ++x)
{
const tcu::Vec4 color(access.getPixel(x, y, z));
tcu::Vec4 newColor = color;
for (int i = 0; i < 4; ++i)
{
if (access.getFormat().type == tcu::TextureFormat::HALF_FLOAT)
{
const tcu::Float16 f(color[i]);
if (f.isDenorm() || f.isInf() || f.isNaN())
newColor[i] = 0.0f;
}
else
{
const tcu::Float32 f(color[i]);
if (f.isDenorm() || f.isInf() || f.isNaN())
newColor[i] = 0.0f;
}
}
if (newColor != color)
access.setPixel(newColor, x, y, z);
}
}
//!< replace invalid pixels in the image (-128)
void replaceSnormReinterpretValues(const tcu::PixelBufferAccess access)
{
DE_ASSERT(tcu::getTextureChannelClass(access.getFormat().type) == tcu::TEXTURECHANNELCLASS_SIGNED_FIXED_POINT);
for (int z = 0; z < access.getDepth(); ++z)
for (int y = 0; y < access.getHeight(); ++y)
for (int x = 0; x < access.getWidth(); ++x)
{
const tcu::IVec4 color(access.getPixelInt(x, y, z));
tcu::IVec4 newColor = color;
for (int i = 0; i < 4; ++i)
{
const int32_t oldColor(color[i]);
if (oldColor == -128)
newColor[i] = -127;
}
if (newColor != color)
access.setPixel(newColor, x, y, z);
}
}
tcu::Vec4 getMiddleValue(VkFormat imageFormat)
{
tcu::TextureFormat format = mapVkFormat(imageFormat);
tcu::TextureFormatInfo fmtInfo = tcu::getTextureFormatInfo(format);
tcu::Vec4 val = (fmtInfo.valueMax - fmtInfo.valueMin) * tcu::Vec4(0.5f);
if (isIntegerFormat(imageFormat))
val = floor(val);
return val;
}
tcu::TextureLevel generateReferenceImage(const tcu::IVec3 &imageSize, const VkFormat imageFormat,
const VkFormat readFormat, bool constantValue = false)
{
// Generate a reference image data using the storage format
tcu::TextureLevel reference(mapVkFormat(imageFormat), imageSize.x(), imageSize.y(), imageSize.z());
const tcu::PixelBufferAccess access = reference.getAccess();
const float storeColorScale = computeStoreColorScale(imageFormat, imageSize);
const float storeColorBias = computeStoreColorBias(imageFormat);
const bool srgbFormat = isSrgbFormat(imageFormat);
const bool intFormat = isIntegerFormat(imageFormat);
const bool storeNegativeValues = isSignedFormat(imageFormat) && (storeColorBias == 0);
const int xMax = imageSize.x() - 1;
const int yMax = imageSize.y() - 1;
for (int z = 0; z < imageSize.z(); ++z)
for (int y = 0; y < imageSize.y(); ++y)
for (int x = 0; x < imageSize.x(); ++x)
{
if (constantValue)
{
access.setPixel(getMiddleValue(imageFormat), x, y, z);
}
else
{
tcu::IVec4 color =
tcu::IVec4(x ^ y ^ z, (xMax - x) ^ y ^ z, x ^ (yMax - y) ^ z, (xMax - x) ^ (yMax - y) ^ z);
if (storeNegativeValues)
color -= tcu::IVec4(deRoundFloatToInt32((float)de::max(xMax, yMax) / 2.0f));
if (intFormat)
access.setPixel(color, x, y, z);
else
{
if (srgbFormat)
access.setPixel(tcu::linearToSRGB(color.asFloat() * storeColorScale + storeColorBias), x, y,
z);
else
access.setPixel(color.asFloat() * storeColorScale + storeColorBias, x, y, z);
}
}
}
// If the image is to be accessed as a float texture, get rid of invalid values
if (isFloatFormat(readFormat) && imageFormat != readFormat)
replaceBadFloatReinterpretValues(
tcu::PixelBufferAccess(mapVkFormat(readFormat), imageSize, access.getDataPtr()));
if (isSnormFormat(readFormat) && imageFormat != readFormat)
replaceSnormReinterpretValues(tcu::PixelBufferAccess(mapVkFormat(readFormat), imageSize, access.getDataPtr()));
return reference;
}
inline tcu::TextureLevel generateReferenceImage(const tcu::IVec3 &imageSize, const VkFormat imageFormat,
bool constantValue = false)
{
return generateReferenceImage(imageSize, imageFormat, imageFormat, constantValue);
}
void flipHorizontally(const tcu::PixelBufferAccess access)
{
const int xMax = access.getWidth() - 1;
const int halfWidth = access.getWidth() / 2;
if (isIntegerFormat(mapTextureFormat(access.getFormat())))
for (int z = 0; z < access.getDepth(); z++)
for (int y = 0; y < access.getHeight(); y++)
for (int x = 0; x < halfWidth; x++)
{
const tcu::UVec4 temp = access.getPixelUint(xMax - x, y, z);
access.setPixel(access.getPixelUint(x, y, z), xMax - x, y, z);
access.setPixel(temp, x, y, z);
}
else
for (int z = 0; z < access.getDepth(); z++)
for (int y = 0; y < access.getHeight(); y++)
for (int x = 0; x < halfWidth; x++)
{
const tcu::Vec4 temp = access.getPixel(xMax - x, y, z);
access.setPixel(access.getPixel(x, y, z), xMax - x, y, z);
access.setPixel(temp, x, y, z);
}
}
inline bool formatsAreCompatible(const VkFormat format0, const VkFormat format1)
{
const bool isAlphaOnly = (isAlphaOnlyFormat(format0) || isAlphaOnlyFormat(format1));
return format0 == format1 ||
(mapVkFormat(format0).getPixelSize() == mapVkFormat(format1).getPixelSize() && !isAlphaOnly);
}
void commandImageWriteBarrierBetweenShaderInvocations(Context &context, const VkCommandBuffer cmdBuffer,
const VkImage image, const Texture &texture,
VkImageAspectFlags aspectMask = VK_IMAGE_ASPECT_COLOR_BIT)
{
const DeviceInterface &vk = context.getDeviceInterface();
const VkImageSubresourceRange fullImageSubresourceRange =
makeImageSubresourceRange(aspectMask, 0u, texture.numMipmapLevels(), 0u, texture.numLayers());
const VkImageMemoryBarrier shaderWriteBarrier =
makeImageMemoryBarrier(VK_ACCESS_SHADER_WRITE_BIT, 0u, VK_IMAGE_LAYOUT_GENERAL, VK_IMAGE_LAYOUT_GENERAL, image,
fullImageSubresourceRange);
vk.cmdPipelineBarrier(cmdBuffer, VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT,
(VkDependencyFlags)0, 0, nullptr, 0, nullptr, 1, &shaderWriteBarrier);
}
void commandBufferWriteBarrierBeforeHostRead(Context &context, const VkCommandBuffer cmdBuffer, const VkBuffer buffer,
const VkDeviceSize bufferSizeBytes)
{
const DeviceInterface &vk = context.getDeviceInterface();
const VkBufferMemoryBarrier shaderWriteBarrier =
makeBufferMemoryBarrier(VK_ACCESS_SHADER_WRITE_BIT, VK_ACCESS_HOST_READ_BIT, buffer, 0ull, bufferSizeBytes);
vk.cmdPipelineBarrier(cmdBuffer, VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, VK_PIPELINE_STAGE_HOST_BIT,
(VkDependencyFlags)0, 0, nullptr, 1, &shaderWriteBarrier, 0, nullptr);
}
//! Copy all layers of an image to a buffer.
void commandCopyImageToBuffer(Context &context, const VkCommandBuffer cmdBuffer, const VkImage image,
const VkBuffer buffer, const VkDeviceSize bufferSizeBytes, const Texture &texture,
VkImageAspectFlags aspectMask = VK_IMAGE_ASPECT_COLOR_BIT)
{
const DeviceInterface &vk = context.getDeviceInterface();
const VkImageSubresourceRange fullImageSubresourceRange =
makeImageSubresourceRange(aspectMask, 0u, 1u, 0u, texture.numLayers());
const VkImageMemoryBarrier prepareForTransferBarrier =
makeImageMemoryBarrier(VK_ACCESS_SHADER_WRITE_BIT, VK_ACCESS_TRANSFER_READ_BIT, VK_IMAGE_LAYOUT_GENERAL,
VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, image, fullImageSubresourceRange);
const VkBufferImageCopy copyRegion = makeBufferImageCopy(texture, aspectMask);
const VkBufferMemoryBarrier copyBarrier =
makeBufferMemoryBarrier(VK_ACCESS_TRANSFER_WRITE_BIT, VK_ACCESS_HOST_READ_BIT, buffer, 0ull, bufferSizeBytes);
vk.cmdPipelineBarrier(cmdBuffer, VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, VK_PIPELINE_STAGE_TRANSFER_BIT,
(VkDependencyFlags)0, 0, nullptr, 0, nullptr, 1, &prepareForTransferBarrier);
vk.cmdCopyImageToBuffer(cmdBuffer, image, VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, buffer, 1u, ©Region);
vk.cmdPipelineBarrier(cmdBuffer, VK_PIPELINE_STAGE_TRANSFER_BIT, VK_PIPELINE_STAGE_HOST_BIT, (VkDependencyFlags)0,
0, nullptr, 1, ©Barrier, 0, nullptr);
}
//! Copy all layers of a mipmap image to a buffer.
void commandCopyMipmapImageToBuffer(Context &context, const VkCommandBuffer cmdBuffer, const VkImage image,
const VkFormat imageFormat, const VkBuffer buffer,
const VkDeviceSize bufferSizeBytes, const Texture &texture)
{
const DeviceInterface &vk = context.getDeviceInterface();
const VkImageSubresourceRange fullImageSubresourceRange =
makeImageSubresourceRange(VK_IMAGE_ASPECT_COLOR_BIT, 0u, texture.numMipmapLevels(), 0u, texture.numLayers());
const VkImageMemoryBarrier prepareForTransferBarrier =
makeImageMemoryBarrier(VK_ACCESS_SHADER_WRITE_BIT, VK_ACCESS_TRANSFER_READ_BIT, VK_IMAGE_LAYOUT_GENERAL,
VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, image, fullImageSubresourceRange);
std::vector<VkBufferImageCopy> copyRegions;
VkDeviceSize bufferOffset = 0u;
for (int32_t levelNdx = 0; levelNdx < texture.numMipmapLevels(); levelNdx++)
{
const VkBufferImageCopy copyParams = {
bufferOffset, // VkDeviceSize bufferOffset;
0u, // uint32_t bufferRowLength;
0u, // uint32_t bufferImageHeight;
makeImageSubresourceLayers(VK_IMAGE_ASPECT_COLOR_BIT, levelNdx, 0u,
texture.numLayers()), // VkImageSubresourceLayers imageSubresource;
makeOffset3D(0, 0, 0), // VkOffset3D imageOffset;
makeExtent3D(texture.layerSize(levelNdx)), // VkExtent3D imageExtent;
};
copyRegions.push_back(copyParams);
bufferOffset += getMipmapLevelImageSizeBytes(texture, imageFormat, levelNdx);
}
const VkBufferMemoryBarrier copyBarrier =
makeBufferMemoryBarrier(VK_ACCESS_TRANSFER_WRITE_BIT, VK_ACCESS_HOST_READ_BIT, buffer, 0ull, bufferSizeBytes);
vk.cmdPipelineBarrier(cmdBuffer, VK_PIPELINE_STAGE_COMPUTE_SHADER_BIT, VK_PIPELINE_STAGE_TRANSFER_BIT,
(VkDependencyFlags)0, 0, nullptr, 0, nullptr, 1, &prepareForTransferBarrier);
vk.cmdCopyImageToBuffer(cmdBuffer, image, VK_IMAGE_LAYOUT_TRANSFER_SRC_OPTIMAL, buffer,
(uint32_t)copyRegions.size(), copyRegions.data());
vk.cmdPipelineBarrier(cmdBuffer, VK_PIPELINE_STAGE_TRANSFER_BIT, VK_PIPELINE_STAGE_HOST_BIT, (VkDependencyFlags)0,
0, nullptr, 1, ©Barrier, 0, nullptr);
}
class StoreTest : public TestCase
{
public:
enum TestFlags
{
FLAG_SINGLE_LAYER_BIND = 0x1, //!< Run the shader multiple times, each time binding a different layer.
FLAG_DECLARE_IMAGE_FORMAT_IN_SHADER = 0x2, //!< Declare the format of the images in the shader code
FLAG_MINALIGN = 0x4, //!< Use bufferview offset that matches the advertised minimum alignment
FLAG_STORE_CONSTANT_VALUE = 0x8, //!< Store constant value
};
StoreTest(tcu::TestContext &testCtx, const std::string &name, const Texture &texture, const VkFormat format,
const VkImageTiling tiling, const uint32_t flags = FLAG_DECLARE_IMAGE_FORMAT_IN_SHADER);
virtual void checkSupport(Context &context) const;
void initPrograms(SourceCollections &programCollection) const;
TestInstance *createInstance(Context &context) const;
private:
const Texture m_texture;
const VkFormat m_format;
const VkImageTiling m_tiling;
const bool m_declareImageFormatInShader;
const bool m_singleLayerBind;
const bool m_minalign;
const bool m_storeConstantValue;
};
StoreTest::StoreTest(tcu::TestContext &testCtx, const std::string &name, const Texture &texture, const VkFormat format,
const VkImageTiling tiling, const uint32_t flags)
: TestCase(testCtx, name)
, m_texture(texture)
, m_format(format)
, m_tiling(tiling)
, m_declareImageFormatInShader((flags & FLAG_DECLARE_IMAGE_FORMAT_IN_SHADER) != 0)
, m_singleLayerBind((flags & FLAG_SINGLE_LAYER_BIND) != 0)
, m_minalign((flags & FLAG_MINALIGN) != 0)
, m_storeConstantValue((flags & FLAG_STORE_CONSTANT_VALUE) != 0)
{
if (m_singleLayerBind)
DE_ASSERT(m_texture.numLayers() > 1);
}
void StoreTest::checkSupport(Context &context) const
{
#ifndef CTS_USES_VULKANSC
if (m_format == VK_FORMAT_A8_UNORM_KHR || m_format == VK_FORMAT_A1B5G5R5_UNORM_PACK16_KHR)
context.requireDeviceFunctionality("VK_KHR_maintenance5");
const VkFormatProperties3 formatProperties(context.getFormatProperties(m_format));
const auto &tilingFeatures = (m_tiling == vk::VK_IMAGE_TILING_OPTIMAL) ? formatProperties.optimalTilingFeatures :
formatProperties.linearTilingFeatures;
if ((m_texture.type() == IMAGE_TYPE_BUFFER) && !m_declareImageFormatInShader &&
!(formatProperties.bufferFeatures & VK_FORMAT_FEATURE_2_STORAGE_WRITE_WITHOUT_FORMAT_BIT_KHR))
TCU_THROW(NotSupportedError, "Format not supported for unformatted stores via storage buffer");
if ((m_texture.type() != IMAGE_TYPE_BUFFER) && !m_declareImageFormatInShader &&
!(tilingFeatures & VK_FORMAT_FEATURE_2_STORAGE_WRITE_WITHOUT_FORMAT_BIT_KHR))
TCU_THROW(NotSupportedError, "Format not supported for unformatted stores via storage images");
if (m_texture.type() == IMAGE_TYPE_CUBE_ARRAY)
context.requireDeviceCoreFeature(DEVICE_CORE_FEATURE_IMAGE_CUBE_ARRAY);
if ((m_texture.type() != IMAGE_TYPE_BUFFER) && !(tilingFeatures & VK_FORMAT_FEATURE_STORAGE_IMAGE_BIT))
TCU_THROW(NotSupportedError, "Format not supported for storage images");
if (m_texture.type() == IMAGE_TYPE_BUFFER &&
!(formatProperties.bufferFeatures & VK_FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_BIT))
TCU_THROW(NotSupportedError, "Format not supported for storage texel buffers");
#else
const VkFormatProperties formatProperties(
getPhysicalDeviceFormatProperties(context.getInstanceInterface(), context.getPhysicalDevice(), m_format));
const auto tilingFeatures = (m_tiling == vk::VK_IMAGE_TILING_OPTIMAL) ? formatProperties.optimalTilingFeatures :
formatProperties.linearTilingFeatures;
if (!m_declareImageFormatInShader)
context.requireDeviceCoreFeature(DEVICE_CORE_FEATURE_SHADER_STORAGE_IMAGE_WRITE_WITHOUT_FORMAT);
if (m_texture.type() == IMAGE_TYPE_CUBE_ARRAY)
context.requireDeviceCoreFeature(DEVICE_CORE_FEATURE_IMAGE_CUBE_ARRAY);
if ((m_texture.type() != IMAGE_TYPE_BUFFER) && !(tilingFeatures & VK_FORMAT_FEATURE_STORAGE_IMAGE_BIT))
TCU_THROW(NotSupportedError, "Format not supported for storage images");
if (m_texture.type() == IMAGE_TYPE_BUFFER &&
!(formatProperties.bufferFeatures & VK_FORMAT_FEATURE_STORAGE_TEXEL_BUFFER_BIT))
TCU_THROW(NotSupportedError, "Format not supported for storage texel buffers");
#endif // CTS_USES_VULKANSC
const auto &vki = context.getInstanceInterface();
const auto physicalDevice = context.getPhysicalDevice();
VkImageFormatProperties imageFormatProperties;
const auto result = vki.getPhysicalDeviceImageFormatProperties(
physicalDevice, m_format, mapImageType(m_texture.type()), m_tiling,
(VK_IMAGE_USAGE_STORAGE_BIT | VK_IMAGE_USAGE_TRANSFER_SRC_BIT), 0, &imageFormatProperties);
if (result != VK_SUCCESS)
{
if (result == VK_ERROR_FORMAT_NOT_SUPPORTED)
TCU_THROW(NotSupportedError, "Format unsupported for tiling");
else
TCU_FAIL("vkGetPhysicalDeviceImageFormatProperties returned unexpected error");
}
if (imageFormatProperties.maxArrayLayers < (uint32_t)m_texture.numLayers())
{
TCU_THROW(NotSupportedError, "This format and tiling combination does not support this number of aray layers");
}
if (imageFormatProperties.maxMipLevels < (uint32_t)m_texture.numMipmapLevels())
{
TCU_THROW(NotSupportedError, "This format and tiling combination does not support this number of miplevels");
}
}
void StoreTest::initPrograms(SourceCollections &programCollection) const
{
const float storeColorScale = computeStoreColorScale(m_format, m_texture.size());
const float storeColorBias = computeStoreColorBias(m_format);
DE_ASSERT(colorScaleAndBiasAreValid(m_format, storeColorScale, storeColorBias));
const uint32_t xMax = m_texture.size().x() - 1;
const uint32_t yMax = m_texture.size().y() - 1;
const std::string signednessPrefix = isUintFormat(m_format) ? "u" : isIntFormat(m_format) ? "i" : "";
const bool storeNegativeValues = isSignedFormat(m_format) && (storeColorBias == 0);
bool useClamp = false;
const std::string colorType = signednessPrefix + "vec4";
std::string colorBaseExpr = colorType + "(";
std::string colorExpr;
if (m_storeConstantValue)
{
tcu::Vec4 val = getMiddleValue(m_format);
if (isIntegerFormat(m_format))
{
colorExpr = colorBaseExpr + de::toString(static_cast<int64_t>(val.x())) + ", " +
de::toString(static_cast<int64_t>(val.y())) + ", " +
de::toString(static_cast<int64_t>(val.z())) + ", " +
de::toString(static_cast<int64_t>(val.w())) + ")";
}
else
{
colorExpr = colorBaseExpr + de::toString(val.x()) + ", " + de::toString(val.y()) + ", " +
de::toString(val.z()) + ", " + de::toString(val.w()) + ")";
}
}
else
{
colorBaseExpr = colorBaseExpr + "gx^gy^gz, " + "(" + de::toString(xMax) + "-gx)^gy^gz, " + "gx^(" +
de::toString(yMax) + "-gy)^gz, " + "(" + de::toString(xMax) + "-gx)^(" + de::toString(yMax) +
"-gy)^gz)";
// Large integer values may not be represented with formats with low bit depths
if (isIntegerFormat(m_format))
{
const int64_t minStoreValue =
storeNegativeValues ? 0 - deRoundFloatToInt64((float)de::max(xMax, yMax) / 2.0f) : 0;
const int64_t maxStoreValue =
storeNegativeValues ? deRoundFloatToInt64((float)de::max(xMax, yMax) / 2.0f) : de::max(xMax, yMax);
useClamp = !isRepresentableIntegerValue(tcu::Vector<int64_t, 4>(minStoreValue), mapVkFormat(m_format)) ||
!isRepresentableIntegerValue(tcu::Vector<int64_t, 4>(maxStoreValue), mapVkFormat(m_format));
}
// Clamp if integer value cannot be represented with the current format
if (useClamp)
{
const tcu::IVec4 bitDepths = tcu::getTextureFormatBitDepth(mapVkFormat(m_format));
tcu::IVec4 minRepresentableValue;
tcu::IVec4 maxRepresentableValue;
switch (tcu::getTextureChannelClass(mapVkFormat(m_format).type))
{
case tcu::TEXTURECHANNELCLASS_UNSIGNED_INTEGER:
{
minRepresentableValue = tcu::IVec4(0);
maxRepresentableValue = (tcu::IVec4(1) << bitDepths) - tcu::IVec4(1);
break;
}
case tcu::TEXTURECHANNELCLASS_SIGNED_INTEGER:
{
minRepresentableValue = -(tcu::IVec4(1) << bitDepths - tcu::IVec4(1));
maxRepresentableValue = (tcu::IVec4(1) << (bitDepths - tcu::IVec4(1))) - tcu::IVec4(1);
break;
}
default:
DE_ASSERT(isIntegerFormat(m_format));
}
colorBaseExpr = "clamp(" + colorBaseExpr + ", " + signednessPrefix + "vec4" +
de::toString(minRepresentableValue) + ", " + signednessPrefix + "vec4" +
de::toString(maxRepresentableValue) + ")";
}
colorExpr = colorBaseExpr + (storeColorScale == 1.0f ? "" : "*" + de::toString(storeColorScale)) +
(storeColorBias == 0.0f ? "" : " + float(" + de::toString(storeColorBias) + ")");
if (storeNegativeValues)
colorExpr += "-" + de::toString(deRoundFloatToInt32((float)deMax32(xMax, yMax) / 2.0f));
}
const int dimension = (m_singleLayerBind ? m_texture.layerDimension() : m_texture.dimension());
const std::string texelCoordStr = (dimension == 1 ? "gx" :
dimension == 2 ? "ivec2(gx, gy)" :
dimension == 3 ? "ivec3(gx, gy, gz)" :
"");
const ImageType usedImageType =
(m_singleLayerBind ? getImageTypeForSingleLayer(m_texture.type()) : m_texture.type());
const std::string imageTypeStr = getShaderImageType(mapVkFormat(m_format), usedImageType);
std::string maybeFmtQualStr = m_declareImageFormatInShader ? ", " + getShaderImageFormatQualifierStr(m_format) : "";
std::ostringstream src;
src << glu::getGLSLVersionDeclaration(glu::GLSL_VERSION_440) << "\n"
<< "\n"
<< "layout (local_size_x = 1, local_size_y = 1, local_size_z = 1) in;\n"
<< "layout (binding = 0" << maybeFmtQualStr << ") writeonly uniform " << imageTypeStr << " u_image;\n";
if (m_singleLayerBind)
src << "layout (binding = 1) readonly uniform Constants {\n"
<< " int u_layerNdx;\n"
<< "};\n";
src << "\n"
<< "void main (void)\n"
<< "{\n"
<< " int gx = int(gl_GlobalInvocationID.x);\n"
<< " int gy = int(gl_GlobalInvocationID.y);\n"
<< " int gz = " << (m_singleLayerBind ? "u_layerNdx" : "int(gl_GlobalInvocationID.z)") << ";\n"
<< " " << colorType << " storedColor = " << colorExpr << ";\n"
<< " imageStore(u_image, " << texelCoordStr << ", storedColor);\n"
<< "}\n";
programCollection.glslSources.add("comp") << glu::ComputeSource(src.str());
}
//! Generic test iteration algorithm for image tests
class BaseTestInstance : public TestInstance
{
public:
BaseTestInstance(Context &context, const Texture &texture, const VkFormat format,
const bool declareImageFormatInShader, const bool singleLayerBind, const bool minalign,
const bool bufferLoadUniform);
virtual tcu::TestStatus iterate(void);
virtual ~BaseTestInstance(void)
{
}
protected:
virtual VkDescriptorSetLayout prepareDescriptors(void) = 0;
virtual tcu::TestStatus verifyResult(void) = 0;
virtual void commandBeforeCompute(const VkCommandBuffer cmdBuffer) = 0;
virtual void commandBetweenShaderInvocations(const VkCommandBuffer cmdBuffer) = 0;
virtual void commandAfterCompute(const VkCommandBuffer cmdBuffer) = 0;
virtual void commandBindDescriptorsForLayer(const VkCommandBuffer cmdBuffer, const VkPipelineLayout pipelineLayout,
const int layerNdx) = 0;
virtual uint32_t getViewOffset(Context &context, const VkFormat format, bool uniform);
const Texture m_texture;
const VkFormat m_format;
const bool m_declareImageFormatInShader;
const bool m_singleLayerBind;
const bool m_minalign;
const bool m_bufferLoadUniform;
const uint32_t m_srcViewOffset;
const uint32_t m_dstViewOffset;
};
BaseTestInstance::BaseTestInstance(Context &context, const Texture &texture, const VkFormat format,
const bool declareImageFormatInShader, const bool singleLayerBind,
const bool minalign, const bool bufferLoadUniform)
: TestInstance(context)
, m_texture(texture)
, m_format(format)
, m_declareImageFormatInShader(declareImageFormatInShader)
, m_singleLayerBind(singleLayerBind)
, m_minalign(minalign)
, m_bufferLoadUniform(bufferLoadUniform)
, m_srcViewOffset(getViewOffset(context, format, m_bufferLoadUniform))
, m_dstViewOffset(
getViewOffset(context, formatHasThreeComponents(format) ? getSingleComponentFormat(format) : format, false))
{
}
tcu::TestStatus BaseTestInstance::iterate(void)
{
const DeviceInterface &vk = m_context.getDeviceInterface();
const VkDevice device = m_context.getDevice();
const VkQueue queue = m_context.getUniversalQueue();
const uint32_t queueFamilyIndex = m_context.getUniversalQueueFamilyIndex();
const Unique<VkShaderModule> shaderModule(
createShaderModule(vk, device, m_context.getBinaryCollection().get("comp"), 0));
const VkDescriptorSetLayout descriptorSetLayout = prepareDescriptors();
const Unique<VkPipelineLayout> pipelineLayout(makePipelineLayout(vk, device, descriptorSetLayout));
const Unique<VkPipeline> pipeline(makeComputePipeline(vk, device, *pipelineLayout, *shaderModule));
const Unique<VkCommandPool> cmdPool(
createCommandPool(vk, device, VK_COMMAND_POOL_CREATE_TRANSIENT_BIT, queueFamilyIndex));
const Unique<VkCommandBuffer> cmdBuffer(
allocateCommandBuffer(vk, device, *cmdPool, VK_COMMAND_BUFFER_LEVEL_PRIMARY));
beginCommandBuffer(vk, *cmdBuffer);
vk.cmdBindPipeline(*cmdBuffer, VK_PIPELINE_BIND_POINT_COMPUTE, *pipeline);
commandBeforeCompute(*cmdBuffer);
const tcu::IVec3 workSize = (m_singleLayerBind ? m_texture.layerSize() : m_texture.size());
const int loopNumLayers = (m_singleLayerBind ? m_texture.numLayers() : 1);
for (int layerNdx = 0; layerNdx < loopNumLayers; ++layerNdx)
{
commandBindDescriptorsForLayer(*cmdBuffer, *pipelineLayout, layerNdx);
if (layerNdx > 0)
commandBetweenShaderInvocations(*cmdBuffer);
vk.cmdDispatch(*cmdBuffer, workSize.x(), workSize.y(), workSize.z());
}
commandAfterCompute(*cmdBuffer);
endCommandBuffer(vk, *cmdBuffer);
submitCommandsAndWait(vk, device, queue, *cmdBuffer);
return verifyResult();
}
//! Base store test implementation
class StoreTestInstance : public BaseTestInstance
{
public:
StoreTestInstance(Context &context, const Texture &texture, const VkFormat format,
const bool declareImageFormatInShader, const bool singleLayerBind, const bool minalign,
const bool storeConstantValue);
protected:
virtual tcu::TestStatus verifyResult(void);
// Add empty implementations for functions that might be not needed
void commandBeforeCompute(const VkCommandBuffer)
{
}
void commandBetweenShaderInvocations(const VkCommandBuffer)
{
}
void commandAfterCompute(const VkCommandBuffer)
{
}
de::MovePtr<BufferWithMemory> m_imageBuffer;
const VkDeviceSize m_imageSizeBytes;
bool m_storeConstantValue;
};
uint32_t BaseTestInstance::getViewOffset(Context &context, const VkFormat format, bool uniform)
{
if (m_minalign)
{
if (!context.getTexelBufferAlignmentFeaturesEXT().texelBufferAlignment)
return (uint32_t)context.getDeviceProperties().limits.minTexelBufferOffsetAlignment;
VkPhysicalDeviceTexelBufferAlignmentPropertiesEXT alignmentProperties;
deMemset(&alignmentProperties, 0, sizeof(alignmentProperties));
alignmentProperties.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_TEXEL_BUFFER_ALIGNMENT_PROPERTIES_EXT;
VkPhysicalDeviceProperties2 properties2;
deMemset(&properties2, 0, sizeof(properties2));
properties2.sType = VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROPERTIES_2;
properties2.pNext = &alignmentProperties;
context.getInstanceInterface().getPhysicalDeviceProperties2(context.getPhysicalDevice(), &properties2);
VkBool32 singleTexelAlignment = uniform ? alignmentProperties.uniformTexelBufferOffsetSingleTexelAlignment :
alignmentProperties.storageTexelBufferOffsetSingleTexelAlignment;
VkDeviceSize align = uniform ? alignmentProperties.uniformTexelBufferOffsetAlignmentBytes :
alignmentProperties.storageTexelBufferOffsetAlignmentBytes;
VkDeviceSize texelSize = formatHasThreeComponents(format) ? tcu::getChannelSize(vk::mapVkFormat(format).type) :
tcu::getPixelSize(vk::mapVkFormat(format));
if (singleTexelAlignment)
align = de::min(align, texelSize);
return (uint32_t)align;
}
return 0;
}
StoreTestInstance::StoreTestInstance(Context &context, const Texture &texture, const VkFormat format,
const bool declareImageFormatInShader, const bool singleLayerBind,
const bool minalign, const bool storeConstantValue)
: BaseTestInstance(context, texture, format, declareImageFormatInShader, singleLayerBind, minalign, false)
, m_imageSizeBytes(getImageSizeBytes(texture.size(), format))
, m_storeConstantValue(storeConstantValue)
{
const DeviceInterface &vk = m_context.getDeviceInterface();
const VkDevice device = m_context.getDevice();
Allocator &allocator = m_context.getDefaultAllocator();
// A helper buffer with enough space to hold the whole image. Usage flags accommodate all derived test instances.
m_imageBuffer = de::MovePtr<BufferWithMemory>(new BufferWithMemory(
vk, device, allocator,
makeBufferCreateInfo(m_imageSizeBytes + m_dstViewOffset,
VK_BUFFER_USAGE_STORAGE_TEXEL_BUFFER_BIT | VK_BUFFER_USAGE_TRANSFER_DST_BIT),
MemoryRequirement::HostVisible));
}
tcu::TestStatus StoreTestInstance::verifyResult(void)
{
const DeviceInterface &vk = m_context.getDeviceInterface();
const VkDevice device = m_context.getDevice();
const tcu::IVec3 imageSize = m_texture.size();
const tcu::TextureLevel reference = generateReferenceImage(imageSize, m_format, m_storeConstantValue);
const Allocation &alloc = m_imageBuffer->getAllocation();
invalidateAlloc(vk, device, alloc);
const tcu::ConstPixelBufferAccess result(mapVkFormat(m_format), imageSize,
(const char *)alloc.getHostPtr() + m_dstViewOffset);
if (comparePixelBuffers(m_context.getTestContext().getLog(), m_texture, m_format, reference.getAccess(), result))
return tcu::TestStatus::pass("Passed");
else
return tcu::TestStatus::fail("Image comparison failed");
}
//! Store test for images
class ImageStoreTestInstance : public StoreTestInstance
{
public:
ImageStoreTestInstance(Context &context, const Texture &texture, const VkFormat format, const VkImageTiling tiling,
const bool declareImageFormatInShader, const bool singleLayerBind, const bool minalign,
const bool storeConstantValue);
protected:
VkDescriptorSetLayout prepareDescriptors(void);
void commandBeforeCompute(const VkCommandBuffer cmdBuffer);
void commandBetweenShaderInvocations(const VkCommandBuffer cmdBuffer);
void commandAfterCompute(const VkCommandBuffer cmdBuffer);
void commandBindDescriptorsForLayer(const VkCommandBuffer cmdBuffer, const VkPipelineLayout pipelineLayout,
const int layerNdx);
de::MovePtr<Image> m_image;
de::MovePtr<BufferWithMemory> m_constantsBuffer;
const VkDeviceSize m_constantsBufferChunkSizeBytes;