-
Notifications
You must be signed in to change notification settings - Fork 470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why can vkFreeDescriptorSets
fail when every other resource releasing functions can't?
#1070
Comments
Note that |
We already have an internal discussion going on about this. It appears this was probably an oversight, and if we can establish that all implementations only return successfully, we'll probably add a restriction to the allowed return value and a Note explaining the discrepancy. We are unlikely to actually change the API to remove the return value, however. |
That is good to hear. Please tell us when you have come to a conclusion internally. |
Seems fixed in 1.1.128 |
Yes, thanks. Lost track of the internal / external issue association. |
Any function that releases a resource, (such as
vkDestroy*
andvkFree*
) cannot fail.With the sole exception of
vkFreeDescriptorSets
.vkFreeDescriptorSets can fail with both
VK_ERROR_OUT_OF_HOST_MEMORY
andVK_ERROR_OUT_OF_DEVICE_MEMORY
.The specification does not provide reasoning for this, and it complicates error handling in language bindings which such as
Vulkan-Hpp
(See PR#338 in Vulkan-Hpp).It would be great to know more about the reasoning behind this decision.
The text was updated successfully, but these errors were encountered: