Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Future Tests #69

Closed
12 tasks
stevk opened this issue Sep 8, 2017 · 6 comments
Closed
12 tasks

Future Tests #69

stevk opened this issue Sep 8, 2017 · 6 comments

Comments

@stevk
Copy link
Contributor

stevk commented Sep 8, 2017

These aren't on the roadmap yet

Positive Tests

  • Max, min values of floats. Only ones with limited ranges?
  • Texture of different types (normal,opaque) using same texture at the same time
  • Alpha_blend, alpha_mask w/ double sided
  • Alpha modes tested with different alpha factors (1, 0, 0.8)
  • Name field with special cases (null string, duplicated)
  • Support of at least eight morphed attributes
  • jpeg textures
  • Different types of URI (web url, texture in bin, glb)
  • Occlusion, roughness, and metallic textures in both a single packed texture as well as each with its own texture.
  • Node with negative scale and double sided (should work if both features work separately, so low pri).

Negative Tests

  • Outside of range for attributes that have float values
  • Model missing a top level feature. E.g. Missing material, or node, etc… (Won't render anything)
@donmccurdy
Copy link

Would like to request a test case using accessor.normalized as well.

@bghgary
Copy link
Collaborator

bghgary commented Nov 1, 2017

The byte and short accessors here are normalized: https://github.com/bghgary/glTF-Asset-Generator/tree/generated-assets/GeneratedAssets/Primitive_Attribute

We somehow lost the note about this in the README. @stevk @kcoley Can you add this back? Thanks!

@kcoley
Copy link
Collaborator

kcoley commented Nov 1, 2017

I can work on adding the note. We will also need to push out an update to the generated assets branch since the normalized bytes and shorts were miscomputed in v0.3. The corrected values are currently available on the develop branch. I'll work on an update for both of these changes.

@donmccurdy
Copy link

Awesome, thanks!

@kcoley
Copy link
Collaborator

kcoley commented Nov 1, 2017

No problem!

Here is an updated release with the proper normalized byte and short values and the updated README. The models have also been changed to the +z forward convention:

https://github.com/bghgary/glTF-Asset-Generator/releases/tag/v0.3.1

@stevk
Copy link
Contributor Author

stevk commented Jun 4, 2019

Consolidated list with #63

@stevk stevk closed this as completed Jun 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants