Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extremely high difficulty to create new IBLs per documented process #257

Closed
cdata opened this issue May 7, 2020 · 1 comment
Closed

Comments

@cdata
Copy link

cdata commented May 7, 2020

For context, I have been trying for a few weeks now (in fits and starts) to incorporate the glTF Sample Viewer into a testing suite that I maintain. I have run into a number of bumps trying to incorporate a custom IBL to the project.

  • It is currently not possible to configure custom lighting for the viewer without source changes Configuring custom IBLs #252
  • The pbr-next branch does not work when built from source; KTX2 files are apparently created with an unexpected version, so models are not lit (see below)
  • Building the glTF-IBL-Sampler for pre-filtering IBLs is really hard on OSX; I was not able to do it without making source code modifications
  • It is not possible to correctly pre-filter IBLs using the prescribed tools when building this project from master because the IBL Sampler produces artifacts suitable for the pbr-next branch (KTX2) and not master (HDR cube maps)

Probably the hardest part has been the shifting nature of the implementation for all the projects. At times I had cobbled together a working collection of projects only to find changes come down that broke everything.

Would it be possible for this project to ensure that master is always in a working state, with documentation that corresponds to what is found on master (or some kind of designated stable release) in all dependent projects?

Unlit model Related error
image image
@UX3D-nopper
Copy link
Contributor

Thank you for the feedback. I created several tickets:

  • It is currently not possible to configure custom lighting for the viewer without source changes Configuring custom IBLs #252
  • The pbr-next branch does not work when built from source; KTX2 files are apparently created with an unexpected version, so models are not lit (see below) MIME update KTX-Specification#18
    At this point of time, there is no official KTX2 mime type.
  • Building the glTF-IBL-Sampler for pre-filtering IBLs is really hard on OSX; I was not able to do it without making source code modifications glTF IBL Sampler can not be used on MacOS X glTF-IBL-Sampler#12
    I made a quick fix for the latest Vulkan SDK and will let it cross check.
  • It is not possible to correctly pre-filter IBLs using the prescribed tools when building this project from master because the IBL Sampler produces artifacts suitable for the pbr-next branch (KTX2) and not master (HDR cube maps)
    To avoid confusion, everything is now in the master branch.

I am closing this ticket, as sub tickets were created. Please create for every bug a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants