-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Animation: sampler.interpolation values #156
Comments
That's a possibility, but I would say only if we agree here: #144 that we support quaternion explicitly. |
OK. I suppose this adds some pressure to supporting quaternions then. |
@fabrobinet do you recall what interpolation the converter expects for rotations? |
@tparisi to close this issue, I suggest we add the following wording to the spec:
|
This is in the spec now. |
AFAIK the only valid
interpolation
in glTF 1.0 isLINEAR
, e.g.,For rotations, both @tparisi and my implementations use slerp, which is "spherical linear" so don't we think
LINEAR
is misleading?Perhaps we
SPHERICAL_LINEAR
for rotations, orinterpolation
from the 1.0 spec and say that all values areLINEAR
except anode.rotation
target, which would beSPHERICAL_LINEAR
.Thinking forward to
material
targets that may have rotation matrices as animated parameters, we may wantSPHERICAL_LINEAR
here (although it implies conversions to/from quaternion) since linear interpolation of rotation matrices does not maintain an orthonormal matrix except at the key frames. Having an explicitSPHERICAL_LINEAR
would also avoid the case of trying to apply slerp to a scale matrix just because it is 3x3.The text was updated successfully, but these errors were encountered: