Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename semantics as attributes property in primitive #162

Closed
fabrobinet opened this issue Oct 21, 2013 · 6 comments
Closed

rename semantics as attributes property in primitive #162

fabrobinet opened this issue Oct 21, 2013 · 6 comments

Comments

@fabrobinet
Copy link
Contributor

We have this:

{
    "indices": "indices_2117",
    "material": "wood",
    "primitive": "TRIANGLES",
    "semantics": {
        "NORMAL": "attribute_2124",
        "POSITION": "attribute_2122",
        "TEXCOORD_0": "attribute_2126"
     }
}

semantics qualifies the keys, it would be more appropriate to qualify the values.

So I propose this:

{
    "indices": "indices_2117",
    "material": "wood",
    "primitive": "TRIANGLES",
    "attributes": {                                
        "NORMAL": "attribute_2124",
        "POSITION": "attribute_2122",
        "TEXCOORD_0": "attribute_2126"
     }
}
@tparisi
Copy link
Contributor

tparisi commented Oct 21, 2013

Yeah I always thought this was wrong. We should change it.

@fabrobinet
Copy link
Contributor Author

Sounds like an easy one, @pjcozzi @RemiArnaud I can change it quickly if you are OK.

@pjcozzi
Copy link
Member

pjcozzi commented Oct 22, 2013

👍

@fabrobinet
Copy link
Contributor Author

pushed in branch 1930ba3

@fabrobinet
Copy link
Contributor Author

converter fix: now on master

@pjcozzi
Copy link
Member

pjcozzi commented Mar 6, 2014

@fabrobinet schema is updated, let's close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants